Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current E2E Tests - Tracking Issue #5325

Closed
geriux opened this issue Dec 15, 2022 · 5 comments
Closed

Current E2E Tests - Tracking Issue #5325

geriux opened this issue Dec 15, 2022 · 5 comments
Labels
Testing Anything related to automated tests

Comments

@geriux
Copy link
Contributor

geriux commented Dec 15, 2022

This is a ticket to keep track of the current E2E tests, the ones that are disabled or any updates related to them.

Current E2E tests

Canaries E2E tests

  • Gutenberg Editor File Block tests
  • Gutenberg Editor Heading tests
  • Gutenberg Editor Image Block tests
  • Gutenberg Editor Slash Inserter tests

Full E2E tests

@geriux geriux added the Testing Anything related to automated tests label Dec 15, 2022
@fluiddot
Copy link
Contributor

In a second iteration of the list, it would be great to identify the ones that could be replaced by an integration test. If an E2E test doesn't really test a native functionality, we should drop it in favor of an integration test.

@geriux
Copy link
Contributor Author

geriux commented Dec 15, 2022

I've gone through the list and I've made some updates in: WordPress/gutenberg#46583

  • Gutenberg Editor Columns Block test (Removed)
    This test was removed since it already has coverage in integration tests (see)
  • Gutenberg Editor Latest Post Block tests (Removed)
    It was migrated to an integration test (see)
  • Gutenberg Editor tests for List block, Gutenberg Editor tests for List block (end), Gutenberg Editor tests for List block (Removed)
    These tests were removed since they were disabled when the new version of the List block V2 was merged, now it uses Inner Blocks so we don't have to test the List implementation with Aztec since is no longer used, we added plenty of integration tests for coverage (see)
  • Gutenberg Editor More Block test (Removed)
    This test was migrated into an integration test (see)
  • Gutenberg Editor Verse Block Tests (Removed)
    This test was moved to their integration tests (see)
  • Gutenberg Editor Separator Block test (Removed)
    This test was migrated into an integration test (see)

I will update the original list once the PR referenced above is merged. Updated.

@geriux
Copy link
Contributor Author

geriux commented Dec 29, 2022

Gutenberg Editor tests for Block insertion 2 will be updated in WordPress/gutenberg#46822 to remove the inserts block before selected block test due to flakiness, now it will be covered by integration tests. I'll update this comment once that PR is merged.

It is now merged ✅

@geriux
Copy link
Contributor Author

geriux commented Jan 4, 2023

As a follow-up of WordPress/gutenberg#46822 I created another PR WordPress/gutenberg#46882 which will remove Gutenberg Editor tests for Block insertion 2 entirely in favor of integration tests, since it doesn't test native features. I will update the main ticket once it gets merged.

Gutenberg Editor tests for Block insertion 2 were finally removed in WordPress/gutenberg#46882

@geriux
Copy link
Contributor Author

geriux commented Oct 23, 2023

This tracking issue hasn't been updated since January, after some discussions in WordPress/gutenberg#55541 (review) which removes other tests that are currently disabled, I think it's best to close this. We can always open new GitHub issues for specific tests if needed.

@geriux geriux closed this as completed Oct 23, 2023
@github-project-automation github-project-automation bot moved this to Done (keep clean, manually) in Mobile Gutenberg Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing Anything related to automated tests
Projects
Status: Done (keep clean, manually)
Development

No branches or pull requests

2 participants