Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Drag & Drop blocks] Block can't be dragged if it's added by replacing a Paragraph block #4807

Closed
fluiddot opened this issue Apr 28, 2022 · 2 comments
Closed

[Drag & Drop blocks] Block can't be dragged if it's added by replacing a Paragraph block #4807

fluiddot opened this issue Apr 28, 2022 · 2 comments
Assignees
@geriux
Labels
Project: Drag & Drop blocks [Type] Bug Something isn't working

Comments

@fluiddot
Copy link
Contributor

Description

Probably related to the changes introduced in WordPress/gutenberg#40480.

When a block is inserted by replacing a Paragraph block, the dragging gesture is disabled for that block while remains selected. However, this only happens after inserting the block, as the dragging works after selecting a different block and selecting the inserter block again.

How to reproduce it:

  1. Open a post/page.
  2. Add a Paragraph block and select it.
  3. Tap on the ➕ button to insert a block.
  4. Insert any block.
  5. Observe that the inserted block replaced the Paragraph block.
  6. Long-press over the inserted block.
  7. Observe that the dragging is not available.
@fluiddot fluiddot mentioned this issue Apr 28, 2022
Merged
@geriux geriux moved this from Todo to In Progress in Gutenberg Mobile: Drag & Drop blocks feature Apr 29, 2022
@geriux geriux self-assigned this Apr 29, 2022
@geriux geriux mentioned this issue May 3, 2022
Merged
@geriux
Copy link
Contributor

geriux commented May 3, 2022

I'm also investigating an issue on Android where the return key doesn't work for the first block

AndroidIssue.mov

@geriux geriux moved this from In Progress to In Review in Gutenberg Mobile: Drag & Drop blocks feature May 4, 2022
@geriux
Copy link
Contributor

geriux commented May 6, 2022

This was addressed in WordPress/gutenberg#40788

@geriux geriux closed this as completed May 6, 2022
Repository owner moved this from In Review to Done in Gutenberg Mobile: Drag & Drop blocks feature May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geriux geriux

Labels
Project: Drag & Drop blocks [Type] Bug Something isn't working
Projects
No open projects
Gutenberg Mobile: Drag & Drop blocks feature
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@geriux @fluiddot