Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Drag & Drop blocks] Dragging chip remains visible when the app goes to the background (only iOS) #4802

Closed
fluiddot opened this issue Apr 27, 2022 · 2 comments
Closed

[Drag & Drop blocks] Dragging chip remains visible when the app goes to the background (only iOS) #4802

fluiddot opened this issue Apr 27, 2022 · 2 comments
Assignees
@geriux
Labels
Project: Drag & Drop blocks [Type] Bug Something isn't working

Comments

@fluiddot
Copy link
Contributor

Description

The drag & drop functionality keeps the chip component visible when the app goes to the background and then resumed.

This could be solved by listening to the app state changes via the AppState API, and canceling the dragging if it goes to the inactive state.

How to reproduce it:

  1. Start dragging a block.
  2. While moving the block, make the app go to the background by swiping up the screen with another finger.
  3. Resume the app and observe that the dragging chip is still shown and can't be dragged unless long-pressing on a block.
@fluiddot fluiddot mentioned this issue Apr 27, 2022
Merged
@geriux geriux moved this from Todo to In Progress in Gutenberg Mobile: Drag & Drop blocks feature Apr 29, 2022
@geriux geriux self-assigned this Apr 29, 2022
Repository owner moved this from In Progress to Done in Gutenberg Mobile: Drag & Drop blocks feature Apr 29, 2022
@fluiddot fluiddot reopened this Apr 29, 2022
@fluiddot fluiddot moved this from Done to In Progress in Gutenberg Mobile: Drag & Drop blocks feature Apr 29, 2022
@fluiddot
Copy link
Contributor Author

(Sorry for closing the issue by mistake 😅 )

@geriux geriux mentioned this issue Apr 29, 2022
Merged
@geriux geriux moved this from In Progress to In Review in Gutenberg Mobile: Drag & Drop blocks feature Apr 29, 2022
@geriux
Copy link
Contributor

geriux commented May 3, 2022

This was handled in WordPress/gutenberg#40729

@geriux geriux closed this as completed May 3, 2022
Repository owner moved this from In Review to Done in Gutenberg Mobile: Drag & Drop blocks feature May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geriux geriux

Labels
Project: Drag & Drop blocks [Type] Bug Something isn't working
Projects
No open projects
Gutenberg Mobile: Drag & Drop blocks feature
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@geriux @fluiddot