-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Button Block: Alignment options not reflected on the front end #4447
Comments
👋 @fluiddot , can you take a look at this one? I can replicate the issue on WPAndroid too (v18.9-rc-2), and it looks like the alignment option is not persisting (I can replicate even by just exiting or updating the post, without going to the preview). Thanks! I marked the ticket as "[Pri] High" since it's about content/setting not persisting. |
I've reproduced this issue also in iOS (18.9) and Android (18.9), and I confirm that the alignment options are not being saved when edited in the native version. I also observed that alignment options are neither reflected in the native version when changed in the web editor. I'll take a deeper look at the code in case this is a breakage coming from recent changes 👀 . |
Looks like this issue was introduced in this PR, as the |
Reminder to self/us: we should add an integration test for this one, to test that the resulting html (say, HTML mode) is persisting the change. |
Oh yeah, I'm actually writing it as I'm fixing the issue 😄 . |
Heads up that I've just created a PR for addressing this issue: WordPress/gutenberg#37887 @hypest I assigned you as a reviewer, let me know if you would be able to take a look, thanks 🙇 ! |
Describe the bug
The mobile app allows to align buttons, the alignment works inside the editor but when previewing the post the alignment is not applied.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
For the preview to show the same alignment as in the editor
Screenshots
Video from user (iPad):
RPReplay_Final1641729227.mp4
Video from testing (iPhone):
RPReplay_Final1641731546-opt.mp4
Smartphone (please complete the following information):
Data from my testing
Additional context
User report: 4655574-zd-woothemes
The text was updated successfully, but these errors were encountered: