Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed Block - Instagram variant doesn't show block settings #3893

Closed
ceyhun opened this issue Aug 31, 2021 · 2 comments
Closed

Embed Block - Instagram variant doesn't show block settings #3893

ceyhun opened this issue Aug 31, 2021 · 2 comments
Assignees
Labels
Embed block [Type] Bug Something isn't working

Comments

@ceyhun
Copy link
Contributor

ceyhun commented Aug 31, 2021

Describe the bug

For Instagram embed block on wpcom web editor we can open the settings and toggle the Resize for smaller devices but on mobile editor the settings icon is not shown in the block and this setting cannot be modified.

To Reproduce
Steps to reproduce the behavior:

  1. Add an Embed block
  2. Paste an Instagram link in the bottom sheet (e.g. https://www.instagram.com/p/Bl6LgZgFDOm)
  3. Close the bottom sheet and wait for the block to load
  4. The Instagram Embed Block doesn't have the settings icon

Expected behavior
Instagram Embed Block should have the settings icon and the ability to toggle the Resize for smaller devices option as it does in the web editor.

Screenshots

Smartphone (please complete the following information):

  • Reproducible on both WPAndroid and WPiOS 18.1 releases

Additional context
Instagram embed variation is disabled on .org which might be related:
https://github.com/WordPress/gutenberg/blob/35e16bbad16afb7209fb0e19b87d3a6f4108dd22/packages/block-library/src/embed/variations.js#L82

Internal reference p5T066-2Bv-p2#comment-9733

@ceyhun ceyhun added [Type] Bug Something isn't working Embed block labels Aug 31, 2021
@fluiddot
Copy link
Contributor

fluiddot commented Sep 2, 2021

I noticed that on WPCom sites when using an Instagram URL, the embed is not using the Instagram variation but the generic one. Maybe this is related to why we have this mismatch between the web and native versions.

Screenshot 2021-09-02 at 12 45 47

@fluiddot fluiddot self-assigned this Sep 29, 2021
@fluiddot
Copy link
Contributor

fluiddot commented Oct 6, 2021

Closing this issue as it has been addressed in #4008.

@fluiddot fluiddot closed this as completed Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Embed block [Type] Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants