Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom Sheet bounces a bit when going from a caption to adding a block #3721

Closed
chipsnyder opened this issue Jul 13, 2021 · 5 comments
Closed
Labels
[Pri] Low [Type] Bug Something isn't working

Comments

@chipsnyder
Copy link
Contributor

Describe the bug
While editing a caption in the Gallery, if you go from an open keyboard to add a new image the bottom sheet bounces up beyond its bounds then settles in place.

To Reproduce
Steps to reproduce the behavior:

  1. Add a Media block or two
  2. Add some images but leave at least one in a state where you can directly access the Choose media sheet.
    • For example you can add a gallery or two image blocks leaving one empty
  3. Add a caption
  4. With the caption still focused Select to add media to the placeholder block from before
  5. Notice the bounce on the bottom sheet as the keyboard hides.

Expected behavior
The bottom sheet will remain fixed at the bottom.

Screenshots
I was able to get it every time while not running a screen recording and 30% of the time while recording.

screenBounce.mp4

Smartphone (please complete the following information):

  • Device: Pixel 3a
  • OS: Android 11
  • Tested in WP Android 17.8-rc-1
@chipsnyder chipsnyder added [Type] Bug Something isn't working [Pri] Low labels Jul 13, 2021
@thehenrybyrd
Copy link

I was able to reproduce on Samsung Galaxy S21, Android 11, WPAndroid 17.8-rc-1.
I was able to get it 100% of the time when editing the caption of the top-right gallery item, but less consistently with the other gallery items.

@mchowning
Copy link
Contributor

Might this be related to any of the work you were doing @fluiddot ?

@dcalhoun
Copy link
Member

dcalhoun commented Jul 15, 2021

For additional context, this may relate to/duplicate WordPress/gutenberg#32012.

@fluiddot
Copy link
Contributor

Might this be related to any of the work you were doing @fluiddot ?

Yeah, probably it's related to the recent changes I did for adding the reusable bocks tab in the bottom sheet, as @dcalhoun pointed out, we already have an open issue related to this.

@hypest
Copy link
Contributor

hypest commented Jul 16, 2021

Thank you all for elaborating and triaging. Let's close this in favor of the one on Gutenberg as the context is already captured there, including videos and all.

@hypest hypest closed this as completed Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Pri] Low [Type] Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants