Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Android Lint in Gutenberg Repo #2653

Open
mchowning opened this issue Sep 22, 2020 · 0 comments
Open

Run Android Lint in Gutenberg Repo #2653

mchowning opened this issue Sep 22, 2020 · 0 comments

Comments

@mchowning
Copy link
Contributor

Summary

I would like us to start running Android lint checks in the Gutenberg PR checks.

Problem

Currently, we do not run Android lint checks in the Gutenberg repository. WPAndroid, however, does run lint on all the Android code in the build, which includes the Android code in Gutenberg. As a result, code that violates lint in Gutenberg passes the Gutenberg and gb-mobile PR builds just fine. When we try to update the submodule hash in WPAndroid, however, that PR build will fail, and we can only fixing it by going back and updating gutenberg.

Solution

I think there are two steps we need to take to solve this problem:

  1. Add the Android lint checks to the Gutenberg PR process (I don't think there's any native code in gb-mobile, so we don't need it here?); and
  2. Once that is done, update the WPAndroid lint checks to exclude gutenberg. This seems important because it will avoid us having to keep the lint checks perfectly in sync between the two projects. Otherwise, I imagine they would eventually get out of sync and we'd be in a scenario where the code that is needed to pass one of the lint checks causes the other lint check to fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant