Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When scrolling a bottomsheet that contains sliders it's very easy to change settings unintentionally #2102

Closed
designsimply opened this issue Apr 2, 2020 · 2 comments · Fixed by WordPress/gutenberg#24120 or #2504
Assignees

Comments

@designsimply
Copy link
Contributor

Describe the bug

Scrolling through settings should not change any settings values. (1m59s)

To Reproduce

  1. Go to My Site > Blog Posts > +.
  2. Add a title.
  3. Add a Latest Posts block.
  4. Tap the gear icon or "CUSTOMIZE" link.
  5. Scroll back and forth through the settings several times and notice how when your finger lands on a slider when trying to scroll that those values get changed inadvertently.

Expected behavior

I expected to be able to scroll through any block settings without unintentionally changing any settings values.

Screenshots

IMG_3709

Tested with WPiOS 14.5.0.1 TestFlight beta on iPhone 11 iOS 13.4.

Smartphone (please complete the following information):

  • Device: iPhone 11
  • OS: iOS 13.4
  • Version: WPiOS 14.5.0.1 TestFlight beta
@pinarol
Copy link
Contributor

pinarol commented Apr 28, 2020

Let's check this one again after this issue is done. The order of which gesture to handle isn't something we directly control with React Native, but that issue will change the foundations of BottomSheet so it may have a chance to fix this as well.

@lukewalczak lukewalczak self-assigned this Jul 17, 2020
@lukewalczak
Copy link
Contributor

We've already gathered some conclusion why it doesn't work properly, discussed and planned how to fix it. The plan is to:

  1. create our custom extended ScrollView component with overwritten value delaysContentOnTouches=YES
  2. create a PR to rn-slider to disable [touchToSeekFeature](https://github.com/react-native-community/react-native-slider/pull/117) for iOS
  3. test slider and app parts where ScrollView is used
  4. Propose a PR to RN

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants