Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot dismiss keyboard while editing in landscape mode on Android #2089

Closed
designsimply opened this issue Apr 1, 2020 · 5 comments
Closed
Labels
[OS] Android Project: Flow improvements Revise/enhance various editing flows [Status] Needs Design [Type] Bug Something isn't working

Comments

@designsimply
Copy link
Contributor

Describe the bug

Tapping "Done" while editing a paragraph block in landscape mode creates a new paragraph block and immediately opens edit mode again without showing the new content or dismissing the keyboard—if you leave the post and re-open it, the page looks blank even if you had added content previously. (1m17s)

To Reproduce

  1. Go to My Sites > Pages > +.
  2. Rotate the device to landscape mode.
  3. Tap the "Start writing…" prompt (the default first block).
  4. Tap the "Done" button.
  5. Tap the "Done" button a few more times.
  6. Try adding some text.
  7. Tap the "Done" button.
  8. Rotate the device back to portrait mode.
  9. Tap the back button to leave the page.
  10. Notice that the page was saved as a draft.
  11. Re-open the post and notice that the content area is blank.
  12. Close and re-open the post again and notice that the content area is no longer blank.

Expected behavior

I expect to be able to edit page content in landscape mode and tap "Done" to return to the post normally and that re-opening a new page after editing will show the same content that it did previously.

Screenshots

Screenshot_20200331-180514

Tested with WPAndroid 14.5-rc-2 on Pixel 3 Android 10.

Smartphone (please complete the following information):

  • Device: Pixel 3
  • OS: Android 10
  • Version: WPAndroid 14.5-rc-2
@designsimply designsimply added [Type] Bug Something isn't working [OS] Android labels Apr 1, 2020
@maxme
Copy link
Contributor

maxme commented Apr 1, 2020

I expect to be able to edit page content in landscape mode and tap "Done" to return to the post normally.

I'm not sure about that, should we only return to "view" mode when the user hides the keyboard? This fullscreen view is not the best experience IMO, I thought we wanted to change that but I can't find any related ticket. cc @iamthomasbishop

I wasn't able to reproduce the blank page situation. I wonder if this is an unrelated problem (thi might be a sync issue).

@maxme
Copy link
Contributor

maxme commented Apr 1, 2020

This fullscreen view is not the best experience IMO, I thought we wanted to change that but I can't find any related ticket.

This was actually implemented: #1842 and reverted: #1989

@designsimply designsimply changed the title Cannot dismiss keyboard while editing in landscape mode on Android and new content doesn't appear if you leave the post and re-open it Cannot dismiss keyboard while editing in landscape mode on Android Apr 1, 2020
@designsimply
Copy link
Contributor Author

Thanks for having a look! I've now found that the empty page issue is separate and was filed at wordpress-mobile/WordPress-Android#11339 and partially fixed in wordpress-mobile/WordPress-Android#11568 (props @jd-alexander 🎉) with one remaining issue being tracked at wordpress-mobile/WordPress-Android#11539. 👍

So the next step for this issue is to get design input/feedback on the fullscreen view.

@hypest hypest added the Project: Flow improvements Revise/enhance various editing flows label Apr 6, 2020
@hypest
Copy link
Contributor

hypest commented Apr 6, 2020

In the meantime while this ticket gets more reviewing, adding it to the [Flow: Improvements] project to keep it in the radar.

@SiobhyB
Copy link
Contributor

SiobhyB commented Feb 21, 2024

In testing the latest version (24.3 beta), I can confirm that content is no longer lost when following the reproduction steps. As the flows and UI described here have changed a lot since this issue was created, I'll go ahead to close, but feel welcome to reopen if anything remains relevant.

@SiobhyB SiobhyB closed this as completed Feb 21, 2024
@github-project-automation github-project-automation bot moved this to Done (keep clean, manually) in Mobile Gutenberg Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[OS] Android Project: Flow improvements Revise/enhance various editing flows [Status] Needs Design [Type] Bug Something isn't working
Projects
Status: Done (keep clean, manually)
Development

No branches or pull requests

4 participants