Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Block: default caption alignment doesn't match in the editor versus previews/front-end #1955

Open
designsimply opened this issue Feb 26, 2020 · 2 comments
Labels

Comments

@designsimply
Copy link
Contributor

Steps to reproduce:

  1. Add an image block.
  2. Set the image size to Thumbnail.
  3. Right-align the image.
  4. Add a caption.
  5. Compare how the caption looks in the editor to how it looks in previews and the front-end.

Result: the caption is centered by default in the editor view but left-aligned in previews and the front-end.

IMG_3379 IMG_3380
Tested with WPiOS 14.3.0.0 TestFlight beta on iPhone 6S iOS 13.3.1.

@designsimply designsimply added the [Type] Bug Something isn't working label Feb 26, 2020
@designsimply designsimply changed the title Image Block: Image Block: default caption alignment doesn't match in the editor versus previews/front-end Image Block: default caption alignment doesn't match in the editor versus previews/front-end Feb 26, 2020
@cameronvoell
Copy link
Contributor

image

I'm able to replicate this issue in the web editor, so it's likely this is a regression in non-mobile specific code. @designsimply Can you verify you are seeing the issue on WordPress.com web as well? (not sure if I have some theme breaking this or if all captions are aligned incorrectly on WordPress.com at the moment).

If you see the issue on web as well then maybe we can troubleshoot alongside gb core team. I found this issue that they might be using to track this issue, but it seems odd that image caption alignment is uncentered everywhere and we didn't notice sooner.

@mchowning
Copy link
Contributor

mchowning commented May 5, 2020

👋 @designsimply ! I'm seeing that the caption now has center alignment under the caption on the preview as well.

Editor Preview
Screen Shot 2020-05-05 at 4 22 05 PM Screen Shot 2020-05-05 at 4 22 54 PM

Do you think there is still an issue here? There is obviously a difference between how the paragraph and caption text is laid out in the editor compared to the frontend, but the alignment seems to match now and I think the other issues may be covered by #1954.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants