Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing block on Mobile loses Ordered List Settings #1304

Closed
mchowning opened this issue Aug 20, 2019 · 6 comments · Fixed by #1619
Closed

Editing block on Mobile loses Ordered List Settings #1304

mchowning opened this issue Aug 20, 2019 · 6 comments · Fixed by #1619
Assignees
Labels
[Type] Bug Something isn't working

Comments

@mchowning
Copy link
Contributor

In gutenberg#15113 the web side added settings for changing the start number in an ordered list and reversing the ordered list. Unfortunately, these changes broke mobile because they used components mobile had not implemented. That was fixed in gutenberg#17070, but we have not implemented those additional settings, so any changes on mobile will override (and lose) those settings from web. See this comment for additional info.

@mchowning
Copy link
Contributor Author

We may have the same issue with respect to the color of a list separator block added from web as a result of #1308

@hypest
Copy link
Contributor

hypest commented Sep 19, 2019

So, if I understand this ticket correctly, editing on mobile a post that has one of those list settings not currently supported on mobile will result in loosing content details?

@mchowning mchowning self-assigned this Sep 20, 2019
@mchowning
Copy link
Contributor Author

So, if I understand this ticket correctly, editing on mobile a post that has one of those list settings not currently supported on mobile will result in losing content details?

That is the concern @hypest . @etoledom raised this concern when we were fixing a crash on mobile, and because we were in the middle of trying to get the release out I did not have time to fully investigate the issue, so I made this ticket to track it.

The separator block color was added in gutenberg 6.3.0 and the reverse and start number settings for list blocks were added in 6.4.0. It looks like my site on WP.com is still using gutenberg 6.2.0, so it's not super easy to verify this issue at this time.

@hypest
Copy link
Contributor

hypest commented Sep 23, 2019

Let's split this into 2 tickets:

  1. Make sure we don't alter the body of the post. So, if those options are used, the mobile editor needs to keep them. Let's have this for the Open Beta.
  2. Display/rendering of the list when those options are in effect. Let's keep this out of the Open Beta.

@mchowning mchowning removed their assignment Sep 24, 2019
@marecar3 marecar3 self-assigned this Oct 21, 2019
@SergioEstevao SergioEstevao self-assigned this Nov 22, 2019
@SergioEstevao
Copy link
Contributor

I'm implementing support for displaying start and reversed properties in Aztec iOS: wordpress-mobile/AztecEditor-iOS#1242

@SergioEstevao
Copy link
Contributor

For the record, even before implementing the necessary changes in Aztec, we were not losing the reversed and save attributes because of Aztec.
I think the problem at the time was that our version of Gutenberg master was behind and not saving the new attributes at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants