Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected blocks no longer have left/right borders on wide viewports #1193

Closed
iamthomasbishop opened this issue Jul 4, 2019 · 5 comments
Closed
Assignees
Labels
HACK 7/2019 HACK week July 2019 [Type] Bug Something isn't working

Comments

@iamthomasbishop
Copy link
Contributor

I believe this is a regression in the latest release, as I can’t reproduce in WPiOS 12.7.4.

iPad Pro 10.5”
B5C8BD92-8DDA-4737-AE3C-BAF2D1C44507

iPhone Xs Max (landscape)
8E54D1CF-F95B-4854-8DC9-3B5A92799AF2

Note: this applies to every block type on the canvas.

@guarani
Copy link
Contributor

guarani commented Mar 13, 2020

Simulator Screen Shot - iPad Pro (12 9-inch) (3rd generation) - 2020-03-13 at 16 31 06

@marecar3, I wonder if this issue can be closed since I'm not seeing the issue on the current Gutenberg version. The above screenshot shows the borders displaying correctly.

@iamthomasbishop
Copy link
Contributor Author

@guarani I think this was fixed alongside some recent work on InnerBlocks. Let's do a thorough double-check and then close if we're not seeing the issue anywhere.

@marecar3
Copy link
Contributor

Thanks, @guarani!
Agree with @iamthomasbishop, if we are sure that it's done we can close it.

@guarani
Copy link
Contributor

guarani commented Mar 13, 2020

I retested on the two devices shown in the original post and this appears fixed.

Device Screenshot
iPhone Xs Max iphonexsmax
iPad Pro 10.5" ipad10-5
Android Emulator Foldable android foldable

@guarani
Copy link
Contributor

guarani commented Mar 16, 2020

Agree with @iamthomasbishop, if we are sure that it's done we can close it.

I've added a screenshot above from Android which also shows the left/right borders. I'm closing this now as I'm unable to reproduce.

@guarani guarani closed this as completed Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HACK 7/2019 HACK week July 2019 [Type] Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants