Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote Block: Undo and Redo consistently don’t work on first line #1158

Closed
thehenrybyrd opened this issue Jun 19, 2019 · 2 comments
Closed
Labels
[Type] Bug Something isn't working

Comments

@thehenrybyrd
Copy link

When pressing the Undo button in the first line of a Quote Block, an extra line is added and it’s no longer possible to press Redo.
However, subsequent lines are able to Undo and Redo without any issues, even though an extra line is added.

See video for a better sense of this:

quoteblock

To reproduce:

  1. Start a new post
  2. Add a Quote Block
  3. Type a line, then undo. Note that you cannot redo.
  4. Type a line, then another line. Note that you can undo and redo.
  5. Now undo again, removing the first line, and not that you can no longer redo.

The extra line being added is referenced here:
#1129 (comment)

I tested this on iOS but it’s also mentioned for Android here: https://wp.me/p5T066-Tx

Tested on iPhone SE, (iOS 12.2) running WPiOS 12.7

@SergioEstevao SergioEstevao added this to the v1.8 milestone Jun 23, 2019
@SergioEstevao SergioEstevao self-assigned this Jun 23, 2019
@SergioEstevao SergioEstevao added the [Type] Bug Something isn't working label Jun 23, 2019
@SergioEstevao
Copy link
Contributor

This is solved on develop and it will be deployed on version 1.8.0

@hypest hypest removed this from the v1.8 milestone Jun 27, 2019
@hypest
Copy link
Contributor

hypest commented Jul 1, 2019

Verified not happening on v1.8 of the block editor. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants