From e32860cc423736096dad513f3e7a4938fdbd8ee7 Mon Sep 17 00:00:00 2001 From: Sergio Estevao Date: Wed, 8 Jul 2020 23:14:36 +0100 Subject: [PATCH 1/2] Make sure podfiles are update before committing to GB repo. Running the pod install could changes the lock file inside the GB repo so we need to run that before we commit the change in Gutenberg. --- bin/release_automation.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/bin/release_automation.sh b/bin/release_automation.sh index 1af609cee3..3d8bccec14 100755 --- a/bin/release_automation.sh +++ b/bin/release_automation.sh @@ -48,6 +48,9 @@ npx json -I -f package.json -e "this.version='$VERSION_NUMBER'" || { echo "Error # Set version number in react-native-editor package.json npx json -I -f gutenberg/packages/react-native-editor/package.json -e "this.version='$VERSION_NUMBER'" || { echo "Error: could not update version in react-native-editor package.json"; exit 1; } +# Make sure podfile is updated +npm run core preios + # Commit react-native-editor package changes cd gutenberg git commit -a -m "Update react-native-editor version to: $VERSION_NUMBER" || { echo "Error: failed to commit changes"; exit 1; } @@ -56,9 +59,6 @@ cd .. # Commit package version update changes git commit -a -m "Update gb mobile version to: $VERSION_NUMBER" || { echo "Error: failed to commit changes"; exit 1; } -# Make sure podfile is updated -npm run core preios - # Update the bundles npm run bundle || { printf "\nError: 'npm bundle' failed.\nIf there is an error stating something like \"Command 'bundle' unrecognized.\" above, perhaps try running 'rm -rf node_modules gutenberg/node_modules && npm install'.\n"; exit 1; } From 047edc98d6454457a7f44b078244e1f8fe5f1a02 Mon Sep 17 00:00:00 2001 From: Sergio Estevao Date: Wed, 8 Jul 2020 23:15:22 +0100 Subject: [PATCH 2/2] Update release pull request template with new paths for pod files. --- .../PULL_REQUEST_TEMPLATE/release_pull_request.md | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE/release_pull_request.md b/.github/PULL_REQUEST_TEMPLATE/release_pull_request.md index e5d28f2d19..d84c522a8c 100644 --- a/.github/PULL_REQUEST_TEMPLATE/release_pull_request.md +++ b/.github/PULL_REQUEST_TEMPLATE/release_pull_request.md @@ -28,11 +28,11 @@ Release for Gutenberg Mobile v1.XX.Y ## Release Submission Checklist -- [ ] Release number was bumped -- [ ] Aztec dependencies are pointing to a stable release - - iOS: 'grep WordPressAztec-iOS RNTAztecView.podspec' - - Android: 'grep aztecVersion react-native-aztec/android/build.gradle' -- [ ] Gutenberg 'Podfile' and 'Podfile.lock' inside './ios/' are updated to the release number -- [ ] Bundle package of the release is updated -- [ ] Check if `RELEASE-NOTES.txt` is updated with all the changes that made it to the release +- [ ] Release number was bumped. +- [ ] Aztec dependencies are pointing to a stable release. + - iOS: 'grep WordPressAztec-iOS RNTAztecView.podspec'. + - Android: 'grep aztecVersion react-native-aztec/android/build.gradle'. +- [ ] Gutenberg 'Podfile' and 'Podfile.lock' inside './gutenberg/packages/react-native-editor/ios/' are updated to the release number and do not point to any development pods. +- [ ] Bundle package of the release is updated . +- [ ] Check if `RELEASE-NOTES.txt` and `gutenberg/packages/react-native-editor/RELEASE-NOTES.txt` are updated with all the changes that made it to the release.