From 4b9e22b28a37a17c1ff04bac26375e97082696fc Mon Sep 17 00:00:00 2001 From: Jorge Leandro Perez Date: Wed, 11 Jul 2018 17:56:25 -0300 Subject: [PATCH 1/4] WordPressAuthenticatorDelegate: Nuking unused Error parameter --- .../Authenticator/WordPressAuthenticatorDelegateProtocol.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/WordPressAuthenticator/Authenticator/WordPressAuthenticatorDelegateProtocol.swift b/WordPressAuthenticator/Authenticator/WordPressAuthenticatorDelegateProtocol.swift index 6488b28b0..4a2e7ea79 100644 --- a/WordPressAuthenticator/Authenticator/WordPressAuthenticatorDelegateProtocol.swift +++ b/WordPressAuthenticator/Authenticator/WordPressAuthenticatorDelegateProtocol.swift @@ -61,7 +61,7 @@ public protocol WordPressAuthenticatorDelegate: class { /// - credentials: WordPress Site Credentials. /// - onCompletion: Closure to be executed on completion. /// - func sync(credentials: WordPressCredentials, onCompletion: @escaping (Error?) -> Void) + func sync(credentials: WordPressCredentials, onCompletion: @escaping () -> Void) /// Signals the Host App that a given Analytics Event has occurred. /// From 6630f76e143e76030a4ec988de2ae8c1f75e4c16 Mon Sep 17 00:00:00 2001 From: Jorge Leandro Perez Date: Wed, 11 Jul 2018 17:56:44 -0300 Subject: [PATCH 2/4] LoginSelfHostedViewController: Dropping unneeded parameter placeholder --- .../Signin/LoginSelfHostedViewController.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/WordPressAuthenticator/Signin/LoginSelfHostedViewController.swift b/WordPressAuthenticator/Signin/LoginSelfHostedViewController.swift index 9b183ee4f..9f1888367 100644 --- a/WordPressAuthenticator/Signin/LoginSelfHostedViewController.swift +++ b/WordPressAuthenticator/Signin/LoginSelfHostedViewController.swift @@ -274,7 +274,7 @@ extension LoginSelfHostedViewController { } let credentials = WordPressCredentials.wporg(username: username, password: password, xmlrpc: xmlrpc, options: options) - delegate.sync(credentials: credentials) { [weak self] _ in + delegate.sync(credentials: credentials) { [weak self] in NotificationCenter.default.post(name: Foundation.Notification.Name(rawValue: WordPressAuthenticator.WPSigninDidFinishNotification), object: nil) self?.showLoginEpilogue(for: credentials) From c88bd4ee574b39182329af7f7ae685360e65fa72 Mon Sep 17 00:00:00 2001 From: Jorge Leandro Perez Date: Wed, 11 Jul 2018 17:56:51 -0300 Subject: [PATCH 3/4] LoginViewController: Dropping unneeded parameter placeholder --- WordPressAuthenticator/Signin/LoginViewController.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/WordPressAuthenticator/Signin/LoginViewController.swift b/WordPressAuthenticator/Signin/LoginViewController.swift index 673630774..80b501c33 100644 --- a/WordPressAuthenticator/Signin/LoginViewController.swift +++ b/WordPressAuthenticator/Signin/LoginViewController.swift @@ -220,7 +220,7 @@ extension LoginViewController { configureStatusLabel(NSLocalizedString("Getting account information", comment: "Alerts the user that wpcom account information is being retrieved.")) - authenticationDelegate.sync(credentials: credentials) { [weak self] _ in + authenticationDelegate.sync(credentials: credentials) { [weak self] in self?.configureStatusLabel("") self?.configureViewLoading(false) From be1e6355adadcd27f5b3b900bb7585e23bed3bab Mon Sep 17 00:00:00 2001 From: Jorge Leandro Perez Date: Wed, 11 Jul 2018 17:57:03 -0300 Subject: [PATCH 4/4] SignupGoogleViewController: Dropping unneeded parameter placeholder --- WordPressAuthenticator/Signup/SignupGoogleViewController.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/WordPressAuthenticator/Signup/SignupGoogleViewController.swift b/WordPressAuthenticator/Signup/SignupGoogleViewController.swift index 7299bfdd8..1be3bf9a6 100644 --- a/WordPressAuthenticator/Signup/SignupGoogleViewController.swift +++ b/WordPressAuthenticator/Signup/SignupGoogleViewController.swift @@ -113,7 +113,7 @@ private extension SignupGoogleViewController { /// Existing Account: We'll synchronize all the things before proceeding to the next screen. /// - self?.authenticationDelegate.sync(credentials: credentials) { _ in + self?.authenticationDelegate.sync(credentials: credentials) { SVProgressHUD.dismiss() self?.wasLoggedInInstead(with: credentials) }