From 9b48b743bbb23f757026012fbaa48679aeee996b Mon Sep 17 00:00:00 2001 From: Tony Li Date: Tue, 16 Jan 2024 09:58:32 +1300 Subject: [PATCH] Remove a deadcode - the `error` variable will never be an `AFError` [`Media.error`][Link] is an `NSError` instance. The casting here `error as? AFError` always fails. [Link]: https://github.com/wordpress-mobile/WordPress-iOS/blob/23.9/WordPress/Classes/Models/Media.m#L215 --- .../Classes/Services/MediaCoordinator.swift | 17 +---------------- 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/WordPress/Classes/Services/MediaCoordinator.swift b/WordPress/Classes/Services/MediaCoordinator.swift index 4bffc4622698..1340478604d7 100644 --- a/WordPress/Classes/Services/MediaCoordinator.swift +++ b/WordPress/Classes/Services/MediaCoordinator.swift @@ -809,22 +809,7 @@ extension Media { let multipartEncodingFailedSampleError = AFError.multipartEncodingFailed(reason: .bodyPartFileNotReachable(at: URL(string: "https://wordpress.com")!)) as NSError // (yes, yes, I know, unwrapped optional. but if creating a URL from this string fails, then something is probably REALLY wrong and we should bail anyway.) - // If we still have enough data to know this is a Swift Error, let's do the actual right thing here: - if let afError = error as? AFError { - guard - case .multipartEncodingFailed = afError, - case .multipartEncodingFailed(let encodingFailure) = afError else { - return false - } - - switch encodingFailure { - case .bodyPartFileNotReachableWithError, - .bodyPartFileNotReachable: - return true - default: - return false - } - } else if let nsError = error as NSError?, + if let nsError = error as NSError?, nsError.domain == multipartEncodingFailedSampleError.domain, nsError.code == multipartEncodingFailedSampleError.code { // and if we only have the NSError-level of data, let's just fall back on best-effort guess.