Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Pause media upload when internet connection unavailable #22282

Merged
merged 11 commits into from
Jan 10, 2024
Merged

feat: Pause media upload when internet connection unavailable #22282

merged 11 commits into from
Jan 10, 2024

Conversation

dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Dec 23, 2023 •
edited
Loading

Related

Description

Pause media upload when internet connection is unavailable.

Testing Instructions

See WordPress/gutenberg#56937.

Regression Notes

  1. Potential unintended areas of impact
    Disrupting successful media uploads, breaking other media block types.
  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Uploaded media to various block types.
  3. What automated tests I added (or what prevented me from doing so)
    No, opted to test the JavaScript logic instead.

PR submission checklist

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@dcalhoun dcalhoun added Media Gutenberg Editing and display of Gutenberg blocks. labels Dec 23, 2023
@dcalhoun
build: Update Gutenberg ref
b49951d
@dcalhoun
feat: Add paused media upload state
f861e30 
When internet connection is unavailable, pause the upload rather than
marking it as failed.
@dcalhoun dcalhoun force-pushed the feat/update-image-block-upload-visuals branch from c7447db to f861e30 Compare December 23, 2023 12:40
@dcalhoun dcalhoun changed the base branch from trunk to feat/automatically-retry-pending-media-uploads December 23, 2023 12:40
@dcalhoun dcalhoun added this to the 24.0 milestone Dec 23, 2023
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 23, 2023 •
edited
Loading

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22282-ab745fc
Version24.0
Bundle IDorg.wordpress.alpha
Commitab745fc
App Center BuildWPiOS - One-Offs #8404
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 23, 2023 •
edited
Loading

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22282-ab745fc
Version24.0
Bundle IDcom.jetpack.alpha
Commitab745fc
App Center Buildjetpack-installable-builds #7427
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@dcalhoun dcalhoun mentioned this pull request Dec 27, 2023
Merged
Base automatically changed from feat/automatically-retry-pending-media-uploads to trunk December 27, 2023 02:33
@dcalhoun dcalhoun linked an issue Jan 1, 2024 that may be closed by this pull request
Modify Image block visuals during offline uploads wordpress-mobile/gutenberg-mobile#6407
Closed
@dcalhoun
feat: Conditionally apply paused media upload state for remote status
4a452da 
Prevent conflicting media upload statuses by applying the paused media
upload logic in additional locations.
@dcalhoun
build: Update Gutenberg ref
5175843
@dcalhoun dcalhoun mentioned this pull request Jan 2, 2024
Merged
@dcalhoun dcalhoun modified the milestones: 24.0, 24.1 Jan 4, 2024
@dcalhoun dcalhoun marked this pull request as ready for review January 4, 2024 21:18
@dcalhoun dcalhoun requested a review from derekblank January 4, 2024 21:18
derekblank
derekblank approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@derekblank derekblank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🚀

@mokagio
Merge remote trunk into feat/update-image-block-upload-visuals
79e311c 
This is necessary to get up to date with a CI configuration change that
requires running on Xcode 15.1.

See #22270
@mokagio
Copy link
Contributor

mokagio commented Jan 8, 2024

Hey @dcalhoun 👋 You might notice a merge trunk commit here from me. That is to bring this branch up to date with the latest CI changes on trunk and ensure everything works on the new Xcode 15.1 CI stack.

Don't hesitate to ping me if there's any trouble.

derekblank and others added 3 commits January 10, 2024 15:28
@derekblank
build: Update Gutenberg ref and merge trunk
d13da3a
@dcalhoun
build: Update Gutenberg ref
e58301e
@dcalhoun
fix: Revert seemingly errant update to Podfile.lock causing CI failures
ab745fc 
The Podfile.lock changes in the branch were unexpected and causing CI
failures.

This changeset was created by the following:

```
git checkout origin/trunk -- Podfile.lock
bundle install
bundle exec pod install
```
@dcalhoun dcalhoun merged commit 7298d9c into trunk Jan 10, 2024
20 of 22 checks passed
@dcalhoun dcalhoun deleted the feat/update-image-block-upload-visuals branch January 10, 2024 16:39
@dcalhoun dcalhoun mentioned this pull request Jan 22, 2024
Closed
@guarani guarani mentioned this pull request Jan 30, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekblank derekblank derekblank approved these changes

Assignees
No one assigned
Labels
Gutenberg Editing and display of Gutenberg blocks. Media
Projects
None yet
Milestone
24.1
Development

Successfully merging this pull request may close these issues.

Modify Image block visuals during offline uploads
4 participants
@dcalhoun @wpmobilebot @mokagio @derekblank