Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Site Dashboard (Phase 2): Create dedicated section for Home item in site menu #17987

Merged
merged 3 commits into from
Feb 23, 2022

Conversation

momo-ozawa
Copy link
Contributor

@momo-ozawa momo-ozawa commented Feb 18, 2022

Part of #17878

Description

  • Updates the "View Site" icon to a globe
  • Updates the "Home" item to be in it's own section
  • Renames dashboard option to "Home" for iPhone

Note

  • The default selected item will still be Stats
  • There is an issue where the correct item isn't highlighted when switching sites. When switching sites via the site picker, the default menu item (i.e. Stats) is displayed in the details view controller. This issue has been present since at least 19.0, and perhaps longer (My Site: Incorrect menu item highlighted after switching site on iPad #17958)

How to test

Make sure the MSD feature flag is enabled

iPad

  1. Go to My Site
  2. ✅ On the sidebar nav, notice that the "Home" item is in it's own section
  3. Scroll down to the "View Site" item
  4. ✅ The "View Site" icon should be a globe
  5. Tap the "Home" item
  6. ✅ The dashboard screen should be displayed in the detail view controller

iPhone

  1. Go to My Site
  2. ✅ The segmented control should have a "Site Menu" and "Home" section
Simulator Screen Shot - iPad Air (4th generation) - 2022-02-18 at 15 07 35 Simulator Screen Shot - iPad Air (4th generation) - 2022-02-18 at 15 19 03 Simulator Screen Shot - iPhone 13 - 2022-02-18 at 15 40 09

Regression Notes

  1. Potential unintended areas of impact
    n/a

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    n/a

  3. What automated tests I added (or what prevented me from doing so)
    n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Momo Ozawa added 3 commits February 18, 2022 14:42
The Home (dashboard) item is using the house icon, so we're updating the View Site item to use the globe icon.
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 18, 2022

You can test the Jetpack changes on this Pull Request by downloading it from AppCenter here with build number: pr17987-635fe17. IPA is available here. If you need access to this, you can ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 18, 2022

You can test the WordPress changes on this Pull Request by downloading it from AppCenter here with build number: pr17987-635fe17. IPA is available here. If you need access to this, you can ask a maintainer to add you.

@pachlava
Copy link
Contributor

pachlava commented Feb 21, 2022

@momo-ozawa I tested on a real iPhone XR, where I saw Dashboard being renamed to Home and the View Site icon change. Found no issues related to the changes 👍

I'm not giving the approval only because I could not test on iPad Simulator - I'll be able to do this only in my evening, in 7-8 hours from now, once I have my laptop back from service. If you wish to merge earlier, please consider that there are * objections from my side 🙂

[EDIT] "there are *NO objections from my side..."

Copy link
Contributor

@leandroalonso leandroalonso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@momo-ozawa momo-ozawa merged commit 0b5976f into trunk Feb 23, 2022
@momo-ozawa momo-ozawa deleted the task/17878-msd-ipad-info-architecture-2 branch February 23, 2022 11:52
@leandroalonso leandroalonso modified the milestones: Someday, 19.6 Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants