Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader Comments: Remove feature flag for Follow Conversation #17714

Merged
merged 7 commits into from
Jan 5, 2022

Conversation

dvdchr
Copy link
Contributor

@dvdchr dvdchr commented Jan 5, 2022

Fixes n/a

As titled, this removes the feature flag for the Follow Conversation feature. This means the feature will be permanently moved from the header view to the navigation bar. In addition, I've also taken the liberty of removing unused code in Reader Comments and the header view.

To test:

Similar testing steps from #17363 should be applicable for this:

  • Go to Reader, and select any unsubscribed post.
  • 🔍 Verify that the "Follow" button should be visible on the navigation bar.
  • Tap the Follow button.
  • 🔍 Verify that the snackbar with the "Enable" action button is shown.
  • Tap on the "Enable" button.
  • 🔍 Verify that a feedback notice with an "Undo" action button is shown.
  • Tap on the "Undo" action button.
  • 🔍 Verify that a feedback notice is shown.
  • 🔍 Verify that the Follow button has turned into a bell icon button in the navigation bar.
  • Go to Reader, and select any subscribed post.
  • Tap on the bell icon button.
  • 🔍 Verify that the bottom sheet is shown.
  • Tap on the switch.
  • Dismiss the bottom sheet.
  • 🔍 Verify that a feedback notification is shown, and correctly represents the desired state.
  • Tap the bell icon button again.
  • Tap on the Unfollow Conversation button.
  • 🔍 Verify that a feedback notification is shown.
  • 🔍 Verify that the bell icon button has now turned back into "Follow".

Regression Notes

  1. Potential unintended areas of impact
    The follow conversation flow may be impacted.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manually tested to ensure that the feature works as expected.

  3. What automated tests I added (or what prevented me from doing so)
    n/a.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@dvdchr dvdchr added this to the 19.0 milestone Jan 5, 2022
@dvdchr dvdchr requested a review from ScoutHarris January 5, 2022 14:23
@dvdchr dvdchr self-assigned this Jan 5, 2022
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jan 5, 2022

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jan 5, 2022

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@ScoutHarris ScoutHarris enabled auto-merge January 5, 2022 19:35
Copy link
Contributor

@ScoutHarris ScoutHarris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

:shipit:

@ScoutHarris
Copy link
Contributor

ScoutHarris commented Jan 5, 2022

Hey @dvdchr . FYI - I enabled auto-merge so I can use this in my feature. I also merged develop to kick off tests again. The unit tests were failing, but locally they ran fine 🤷 . 🤞 !

@ScoutHarris ScoutHarris merged commit 467afc9 into develop Jan 5, 2022
@ScoutHarris ScoutHarris deleted the feature/remove-follow-conversation-flag branch January 5, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants