-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reader Comments: Remove feature flag for Follow Conversation #17714
Conversation
You can trigger an installable build for these changes by visiting CircleCI here. |
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hey @dvdchr . FYI - I enabled auto-merge so I can use this in my feature. I also merged |
Fixes n/a
As titled, this removes the feature flag for the Follow Conversation feature. This means the feature will be permanently moved from the header view to the navigation bar. In addition, I've also taken the liberty of removing unused code in Reader Comments and the header view.
To test:
Similar testing steps from #17363 should be applicable for this:
Regression Notes
Potential unintended areas of impact
The follow conversation flow may be impacted.
What I did to test those areas of impact (or what existing automated tests I relied on)
Manually tested to ensure that the feature works as expected.
What automated tests I added (or what prevented me from doing so)
n/a.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.