-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Empty stats: nudge presentation logic fixes #17377
Empty stats: nudge presentation logic fixes #17377
Conversation
You can trigger an installable build for these changes by visiting CircleCI here. |
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
…od to include hintType parameter
…e.currentItem matches
@@ -307,5 +310,16 @@ extension GrowAudienceCell { | |||
return UIImage(named: "grow-audience-illustration-reader") | |||
} | |||
} | |||
|
|||
var userDefaultsKey: String { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried a few things to get rid of this but no luck. 😢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup 😬
Fixes #17371
FIxes #17376
Test first nudge shown again after all the nudges are dismissed
Test dismissing the completed nudge card dismisses the next (not completed) nudge
Regression Notes
Potential unintended areas of impact
n/a
What I did to test those areas of impact (or what existing automated tests I relied on)
n/a
What automated tests I added (or what prevented me from doing so)
n/a
PR submission checklist:
RELEASE-NOTES.txt
if necessary.