Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty stats: nudge presentation logic fixes #17377

Conversation

nikola-milicevic
Copy link
Contributor

@nikola-milicevic nikola-milicevic commented Oct 27, 2021

Fixes #17371
FIxes #17376

Test first nudge shown again after all the nudges are dismissed

  1. Do a fresh install of WPiOS
  2. On My Site select a site with more than 30 views
  3. Dismiss the Customize Insights card, then go back to My Site
  4. On My Site select a site with less than 30 views
  5. Go to Stats
  6. Dismiss the first empty stats nudge, then go back to My Site
  7. Go to Stats
  8. Dismiss the second empty stats nudge, then go back to My Site
  9. Go to Stats
  10. Complete the Reader Discover nudge flow, then go back to My Site
  11. Go to Stats
  12. No nudge cards should be shown

Test dismissing the completed nudge card dismisses the next (not completed) nudge

  1. Complete Publicize or Blogging reminders nudge on the My site > Stats screen
  2. Completed nudge card is presented for that nudge (that has just been completed)
  3. Tap Dismiss on that card
  4. Go back to My site and back again to Stats screen
  5. The next nudge should be presented

Regression Notes

  1. Potential unintended areas of impact
    n/a

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    n/a

  3. What automated tests I added (or what prevented me from doing so)
    n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Oct 27, 2021

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Oct 27, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@nikola-milicevic nikola-milicevic removed the request for review from momo-ozawa October 27, 2021 10:45
@nikola-milicevic nikola-milicevic modified the milestones: Someday, 18.6 Oct 27, 2021
@nikola-milicevic nikola-milicevic marked this pull request as ready for review October 27, 2021 10:46
@nikola-milicevic nikola-milicevic modified the milestone: 18.6 Oct 27, 2021
@@ -307,5 +310,16 @@ extension GrowAudienceCell {
return UIImage(named: "grow-audience-illustration-reader")
}
}

var userDefaultsKey: String {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried a few things to get rid of this but no luck. 😢

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup 😬

@nikola-milicevic nikola-milicevic merged commit e9b4e68 into task/empty-stats-reader-discover-nudge Oct 27, 2021
@nikola-milicevic nikola-milicevic deleted the fix/empty-stats-nudge-presentation-logic branch October 27, 2021 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants