-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reader Post: Add receivesCommentNotifications property #17322
Reader Post: Add receivesCommentNotifications property #17322
Conversation
Generated by 🚫 dangerJS |
You can trigger an installable build for these changes by visiting CircleCI here. |
…t-add-receivesNotification-property
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Howdy @dvdchr 👋
Looks great! I did a smoke test of the reader and everything seemed to work as expected. Changes to the data model look good to me.
!
Thank you @aerych ! |
Depends on: wordpress-mobile/WordPressKit-iOS#452 👈 Please review this first 🙂
Adds
receivesCommentNotifications
toReaderPost
. This will be used by the upcoming PRs to enable post subscribers to receive push notifications. The default value of thereceivesCommentNotifications
is set tofalse
because the push notification feature is opt-out by default, so this checks out.To Test
Regression Notes
Potential unintended areas of impact
Potential crash when parsing the new property?
What I did to test those areas of impact (or what existing automated tests I relied on)
Ensure that all the screens depending on
ReaderPost
objects work fine.What automated tests I added (or what prevented me from doing so)
n/a.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.