Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signup Flow Password Field #17927

Closed
startuptester opened this issue Feb 10, 2022 · 5 comments
Closed

Signup Flow Password Field #17927

startuptester opened this issue Feb 10, 2022 · 5 comments

Comments

@startuptester
Copy link
Contributor

Expected behavior

If I tap to enter an optional password in the magic link flow and then change my mind, I want to dismiss the keyboard and move on.

Actual behavior

I am unable to dismiss the keyboard and I have to either tap the name field to edit my username and then go back, or create a password.

Steps to reproduce the behavior

  1. Start the email address signup flow
  2. Open the email and tap the magic link
  3. When the app opens, you should see the screen with your username and an optional password creation field
  4. If you tap in that field (and tell keychain you want to create your own), there is no way to dismiss the keyboard so you can't change your mind. You either have to create a password or tap on the username field and then go back to this screen.
Tested on iPhone 13, iOS 15.3, WPiOS 19.1
@guarani
Copy link
Contributor

guarani commented Feb 10, 2022

I can reproduce this issue, thanks for reporting @startuptester!

The issue is that the keyboard covers the "Done" button. iPadOS provides a handy "keyboard dismiss" button so this is not an issue there, but on iPhones there is no such button.

The options I see are:

  1. Put a custom "close keyboard" button above the keyboard
  2. Make the blue "Done" button always sits above (floats above) the keyboard (of course, when the keyboard is not shown, it should go back to its normal current position at the bottom of the screen)
  3. Make the keyboard dismiss by "swiping down" or "dragging down" from just above the keyboard
  4. Make the keyboard dismiss by tapping anywhere on the screen (anywhere where there is not a text input or button)

My first preference is Option 2 because it's more intuitive for the user since they don't need to guess that the "Done" button might be behind the keyboard. The challenge might be to make this work on smaller devices such as the iPhone 13 mini where there is less space for a "Done" button between the existing content and the keyboard.

My second preference would be option 3. Dragging down to hide the keyboard is a familiar gesture to users who use iOS' system Messages app, but is not super intuitive to all users (they have to guess there is a Done button behind the keyboard).

@guarani
Copy link
Contributor

guarani commented Feb 10, 2022

I found that smaller devices (e.g. iPhone 13 mini) don't have space to float the "Done" button between existing screen content and the keyboard, so I went with Option 3 (drag down to dismiss keyboard):

RPReplay_Final1644524452.MP4

I've made a draft PR while I continue testing this.

@guarani
Copy link
Contributor

guarani commented Feb 11, 2022

I only just realized the above screen-recording doesn't show the keyboard 🤦 😄

@startuptester
Copy link
Contributor Author

I only just realized the above screen-recording doesn't show the keyboard 🤦 😄

haha yep. I tried to include one too and realized the same 😆

@guarani
Copy link
Contributor

guarani commented Mar 16, 2022

Closed via #17938.

@guarani guarani closed this as completed Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants