-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signup Flow Password Field #17927
Comments
I can reproduce this issue, thanks for reporting @startuptester! The issue is that the keyboard covers the "Done" button. iPadOS provides a handy "keyboard dismiss" button so this is not an issue there, but on iPhones there is no such button. The options I see are:
My first preference is Option 2 because it's more intuitive for the user since they don't need to guess that the "Done" button might be behind the keyboard. The challenge might be to make this work on smaller devices such as the iPhone 13 mini where there is less space for a "Done" button between the existing content and the keyboard. My second preference would be option 3. Dragging down to hide the keyboard is a familiar gesture to users who use iOS' system Messages app, but is not super intuitive to all users (they have to guess there is a Done button behind the keyboard). |
I found that smaller devices (e.g. iPhone 13 mini) don't have space to float the "Done" button between existing screen content and the keyboard, so I went with Option 3 (drag down to dismiss keyboard): RPReplay_Final1644524452.MP4I've made a draft PR while I continue testing this. |
I only just realized the above screen-recording doesn't show the keyboard 🤦 😄 |
haha yep. I tried to include one too and realized the same 😆 |
Closed via #17938. |
Expected behavior
If I tap to enter an optional password in the magic link flow and then change my mind, I want to dismiss the keyboard and move on.
Actual behavior
I am unable to dismiss the keyboard and I have to either tap the name field to edit my username and then go back, or create a password.
Steps to reproduce the behavior
Tested on iPhone 13, iOS 15.3, WPiOS 19.1
The text was updated successfully, but these errors were encountered: