Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sharing button in the Me screen. #16996

Closed
Tracked by #16995
dvdchr opened this issue Aug 9, 2021 · 0 comments · Fixed by #17020
Closed
Tracked by #16995

Add sharing button in the Me screen. #16996

dvdchr opened this issue Aug 9, 2021 · 0 comments · Fixed by #17020
Assignees

Comments

@dvdchr
Copy link
Contributor

dvdchr commented Aug 9, 2021

Parent issue: #16995

Implement the "Share WordPress with a friend" button in the Me screen.

Some notes:

  • The screen uses ImmuTable, but the design reuses existing style (an IndicatorNavigationItemRow) which should make the effort fairly straightforward, provided Add component to handle content fetching and presentation logic #17003 is done.
  • The current IndicatorNavigationItemRow is not capable to handle loading states, so some kind of loading functionality needs to be added. The other alternative is to take a look at some activity indicator rows already present in ImmuTableRows.
    • If there's no suitable existing ImmuTableRow component, then it's possible to create an IndicatorNavigationItemRow variant that shows an activity indicator for the accessory view slot.
  • There might be a some small reorganizing required for the tableViewModel computed property in MeViewController since the row is only added when the feature flag is enabled.

Design

Screen Shot 2021-08-12 at 18 18 05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant