Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Auto-upload Published] Automatically upload published and draft posts with existing remote #12324

Closed
1 of 2 tasks
shiki opened this issue Aug 14, 2019 · 4 comments
Closed
1 of 2 tasks

[Auto-upload Published] Automatically upload published and draft posts with existing remote #12324

shiki opened this issue Aug 14, 2019 · 4 comments
Assignees
@leandroalonso
Labels
Offline Support [Pri] High [Type] Task

Comments

@shiki
Copy link
Member

shiki commented Aug 14, 2019 •
edited
Loading

Part of #12240.

This requires #12317 and #12136 to be completed first. Any changes should target the issue/12240-master-branch branch.

All the work that's been done up to #12136 only supports drafts and published posts created on the device. If the post was uploaded to the server and the user edits it, we do not automatically it. The goal of this task is to support this.

Keep in mind, that there are rules for when we should auto-upload or remote auto-saved. They are described in the Test Specs section of #12240.

Other Tasks
@shiki shiki added [Type] Task Offline Support [Status] Blocked Waiting for a different task to be able to proceed labels Aug 14, 2019
@shiki shiki changed the title [Auto-upload Published] Automatically upload published and draft posts with remote [Auto-upload Published] Automatically upload published and draft posts with existing remote Aug 14, 2019
@shiki shiki mentioned this issue Aug 14, 2019
Merged
1 task
@shiki shiki self-assigned this Aug 22, 2019
@shiki shiki removed the [Status] Blocked Waiting for a different task to be able to proceed label Aug 22, 2019
@shiki shiki removed their assignment Aug 26, 2019
@shiki shiki self-assigned this Aug 28, 2019
This was referenced Aug 31, 2019
Closed
Closed
Merged
@shiki
Copy link
Member Author

shiki commented Oct 1, 2019

Done in #12466

@shiki shiki closed this as completed Oct 1, 2019
@shiki
Copy link
Member Author

shiki commented Oct 1, 2019

The task “We should not automatically upload or remote auto-save when the post is in conflict with remote. We should add a unit test for this.“ can be done later. Possibly when #12141 is shipped.

@shiki
Copy link
Member Author

shiki commented Oct 1, 2019

Reopening this since there is a regression in the master branch. @leandroalonso is currently working on it.

@shiki shiki reopened this Oct 1, 2019
@shiki shiki assigned leandroalonso and unassigned shiki Oct 1, 2019
@leandroalonso leandroalonso mentioned this issue Oct 1, 2019
Merged
2 tasks
@shiki
Copy link
Member Author

shiki commented Oct 1, 2019

Fixed again in #12594

@shiki shiki closed this as completed Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leandroalonso leandroalonso

Labels
Offline Support [Pri] High [Type] Task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shiki @leandroalonso