From 40f6676fe9e245b0519ac0d650e9e60864251861 Mon Sep 17 00:00:00 2001 From: Olivier Halligon Date: Fri, 17 Dec 2021 17:59:06 +0100 Subject: [PATCH] Remove call to extract-framework-translation while work on L10n tooling is still WIP MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We are currently working on removing `update-translations.rb` + `fix-translations` + `extract-framework-translations.swift` scripts from the repo and migrating their logic into the release-toolkit, but that work is still in progress. The role of the (misleadingly named) `extract-frameworks-translations.swift` script was to redistribute the keys from the `*.lproj/Localizable.strings` downloaded from GlotPress into the `.strings` files of the Widgets and ShareExtension targets, back when those targets used their own `.strings` file. This is no longer the case since #17630 and #17636 landed – as Widgets and ShareExtension's code now reference the app's `.strings` file directly – which means we don't need to run the logic from `extract-frameworks-translations.swift` anymore, and in fact if we did, it would probably crash now that the `Base.lproj/Localizable.strings` files in the Widgets and ShareExtension subfolders (which that script references) don't exist anymore. --- Scripts/update-translations.rb | 4 ---- 1 file changed, 4 deletions(-) diff --git a/Scripts/update-translations.rb b/Scripts/update-translations.rb index 2902790e3292..df826f4720fc 100755 --- a/Scripts/update-translations.rb +++ b/Scripts/update-translations.rb @@ -162,7 +162,3 @@ # Clean up after ourselves FileUtils.rm_f backup_destination end - -extract_framework_translations_script_path = File.join(script_root, 'extract-framework-translations.swift') - -system extract_framework_translations_script_path if strings_filter.empty?