From 9dd68a01a8a6ba86156d25a2a31548caa8ecde74 Mon Sep 17 00:00:00 2001 From: Daniele Bogo Date: Thu, 15 Nov 2018 14:48:27 +0000 Subject: [PATCH 1/3] Bump WP Shared to 1.5.0-beta.1 --- Podfile | 2 +- Podfile.lock | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Podfile b/Podfile index 9cead3c3f374..e8859a89537a 100644 --- a/Podfile +++ b/Podfile @@ -24,7 +24,7 @@ end ## def wordpress_shared ## for production: - pod 'WordPressShared', '~> 1.4' + pod 'WordPressShared', '~> 1.5.0-beta.1' ## for development: ## pod 'WordPressShared', :path => '../WordPress-iOS-Shared' diff --git a/Podfile.lock b/Podfile.lock index 41b2641d2cd2..b53cbfc10f2f 100644 --- a/Podfile.lock +++ b/Podfile.lock @@ -127,7 +127,7 @@ PODS: - UIDeviceIdentifier (~> 0.4) - WordPressShared (~> 1.4) - wpxmlrpc (= 0.8.3) - - WordPressShared (1.4.0): + - WordPressShared (1.5.0-beta.1): - CocoaLumberjack (~> 3.4) - FormatterKit/TimeIntervalFormatter (= 1.8.2) - WordPressUI (1.1.0) @@ -172,7 +172,7 @@ DEPENDENCIES: - WordPress-Editor-iOS (= 1.2) - WordPressAuthenticator (~> 1.1) - WordPressKit (~> 1.4.5-beta.1) - - WordPressShared (~> 1.4) + - WordPressShared (~> 1.5.0-beta.1) - WordPressUI (~> 1.1) - WPMediaPicker (= 1.3.1) - wpxmlrpc (= 0.8.3) @@ -258,12 +258,12 @@ SPEC CHECKSUMS: WordPress-Editor-iOS: 28339c1311dcdfdd9e50aba60dcf4c35184d032f WordPressAuthenticator: 0e60d89e1637212bc841a0cf66fc5ef8cac01e52 WordPressKit: 7363364daa6a642f955453479924442ca522e5f1 - WordPressShared: f55be10963c8f6dbbc8e896450805ba1dd5353f7 + WordPressShared: f6272345642887904f5aefff9d65d566e6c5d634 WordPressUI: d3dbd0258f12560d6607647d3240c62c83e089fe WPMediaPicker: ea92f84950843c7baf6a7325caed72ad7852418d wpxmlrpc: bfc572f62ce7ee897f6f38b098d2ba08732ecef4 ZendeskSDK: 44ee00338dd718495f0364369420ae11b389c878 -PODFILE CHECKSUM: 7c58d52ceab28334e39e017a77e54452df200db9 +PODFILE CHECKSUM: 6f40406b0b30c04a7f2f209a1f1373e658bd3a75 COCOAPODS: 1.5.3 From 6883f3780ed1a80fde7f8903ca2b1986cf380057 Mon Sep 17 00:00:00 2001 From: Daniele Bogo Date: Thu, 15 Nov 2018 14:48:39 +0000 Subject: [PATCH 2/3] Implement 3 new events --- .../Analytics/WPAnalyticsTrackerAutomatticTracks.m | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/WordPress/Classes/Utility/Analytics/WPAnalyticsTrackerAutomatticTracks.m b/WordPress/Classes/Utility/Analytics/WPAnalyticsTrackerAutomatticTracks.m index cdc0e79fcee4..de2be4163bc9 100644 --- a/WordPress/Classes/Utility/Analytics/WPAnalyticsTrackerAutomatticTracks.m +++ b/WordPress/Classes/Utility/Analytics/WPAnalyticsTrackerAutomatticTracks.m @@ -944,6 +944,15 @@ + (TracksEventPair *)eventPairForStat:(WPAnalyticsStat)stat case WPAnalyticsStatPluginSearchPerformed: eventName = @"plugin_search_performed"; break; + case WPAnalyticsStatPageSetParentViewed: + eventName = @"site_pages_set_parent_viewed"; + break; + case WPAnalyticsStatPageSetParentSearchAccessed: + eventName = @"site_pages_set_parent_search_accessed"; + break; + case WPAnalyticsStatPageSetParentDonePressed: + eventName = @"site_pages_set_parent_done_pressed"; + break; case WPAnalyticsStatPostEpilogueDisplayed: eventName = @"post_epilogue_displayed"; break; From d390ca8a03a61afa4536dfd67c15b8708df94fc5 Mon Sep 17 00:00:00 2001 From: Daniele Bogo Date: Thu, 15 Nov 2018 15:02:31 +0000 Subject: [PATCH 3/3] Add events for set parent page vc --- .../Pages/ParentPageSettingsViewController.swift | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/WordPress/Classes/ViewRelated/Pages/ParentPageSettingsViewController.swift b/WordPress/Classes/ViewRelated/Pages/ParentPageSettingsViewController.swift index fc72bc9e5a12..f44ed31488cd 100644 --- a/WordPress/Classes/ViewRelated/Pages/ParentPageSettingsViewController.swift +++ b/WordPress/Classes/ViewRelated/Pages/ParentPageSettingsViewController.swift @@ -86,6 +86,12 @@ class ParentPageSettingsViewController: UIViewController { stopListeningToKeyboardNotifications() } + override func viewDidAppear(_ animated: Bool) { + super.viewDidAppear(animated) + + WPAnalytics.track(.pageSetParentViewed) + } + func set(pages: [Page], for page: Page) { selectedPage = page @@ -226,6 +232,8 @@ class ParentPageSettingsViewController: UIViewController { // MARK: IBAction @IBAction func doneAction(_ sender: UIBarButtonItem) { + WPAnalytics.track(.pageSetParentDonePressed) + SVProgressHUD.setDefaultMaskType(.clear) SVProgressHUD.show(withStatus: NSLocalizedString("Updating...", comment: "Text displayed in HUD while a draft or scheduled post is being updated.")) @@ -323,6 +331,7 @@ extension ParentPageSettingsViewController: UISearchBarDelegate { func searchBarTextDidBeginEditing(_ searchBar: UISearchBar) { isSearching = true searchBar.showsCancelButton = true + WPAnalytics.track(.pageSetParentSearchAccessed) } func searchBarTextDidEndEditing(_ searchBar: UISearchBar) {