Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix slug not set on self hosted sites #1483

Merged
merged 2 commits into from
Jan 22, 2020
Merged

Fix slug not set on self hosted sites #1483

merged 2 commits into from
Jan 22, 2020

Conversation

ashiagr
Copy link
Contributor

@ashiagr ashiagr commented Jan 22, 2020

This PR tries to fix #11040 to set slug on self-hosted sites.

To Test

  • Open a published post on a self-hosted site
  • Open Post settings
  • Set a slug
  • Click on Update
  • Open the post again and notice the slug is present

ezgif com-video-to-gif

@ashiagr
Set post_name as slug
01288b4 
XML-RPC WordPress API/Posts documentation mentions
 string post_name: Encoded URL (slug)
@ashiagr
Set post_name as slug in content struct
5cec435
@ashiagr ashiagr requested a review from malinajirka January 22, 2020 07:11
@ashiagr ashiagr self-assigned this Jan 22, 2020
@malinajirka malinajirka self-assigned this Jan 22, 2020
malinajirka
malinajirka approved these changes Jan 22, 2020
View reviewed changes
Copy link
Contributor

@malinajirka malinajirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested the changes and it works as expected. Thank you @ashiagr!

@malinajirka malinajirka merged commit f18e8d7 into develop Jan 22, 2020
@malinajirka malinajirka deleted the issue-11040-slug-not-set-on-self-hosted-sites branch January 22, 2020 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malinajirka malinajirka malinajirka approved these changes

Assignees

@ashiagr ashiagr

@malinajirka malinajirka

Labels
[Store] Post
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Slug isn't being set on self-hosted sites
2 participants
@ashiagr @malinajirka