Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify and report network failure errors #506

Open
aforcier opened this issue Jul 4, 2017 · 3 comments
Open

Identify and report network failure errors #506

aforcier opened this issue Jul 4, 2017 · 3 comments

Comments

@aforcier
Copy link
Contributor

aforcier commented Jul 4, 2017

Identify ConnectException and UnknownHostExceptions in BaseRequest and report them as a distinct error (not UNKNOWN) - and float them up to OnChanged events (instead of reporting as GENERIC_ERROR).

We can get a ConnectException when the connection is interrupted while a request is being sent (e.g. turning on airplane mode), and we can get an UnknownHostException when attemping to make a request while already in airplane mode or lacking a connection.

It's possible we might get UnknownHostException in other cases as well, so we might not want to identify this one as a NO_CONNECTION error, but rather as a NETWORK_ERROR - but we should think through the various GenericErrorTypes anyway.

Note: This has been done for media uploads, which use OkHttpClient directly and don't share the same error reporting as the other endpoints (#505).

@mzorz
Copy link
Contributor

mzorz commented Oct 19, 2017

This one was closed in #505

@mzorz mzorz closed this as completed Oct 19, 2017
@aforcier
Copy link
Contributor Author

@mzorz this issue isn't actually done - we still need to handle these exceptions in the general case - all #505 did was do it for media uploads.

@aforcier aforcier reopened this Oct 19, 2017
@mzorz
Copy link
Contributor

mzorz commented Oct 19, 2017

thanks @aforcier!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants