You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Identify ConnectException and UnknownHostExceptions in BaseRequest and report them as a distinct error (not UNKNOWN) - and float them up to OnChanged events (instead of reporting as GENERIC_ERROR).
We can get a ConnectException when the connection is interrupted while a request is being sent (e.g. turning on airplane mode), and we can get an UnknownHostException when attemping to make a request while already in airplane mode or lacking a connection.
It's possible we might get UnknownHostException in other cases as well, so we might not want to identify this one as a NO_CONNECTION error, but rather as a NETWORK_ERROR - but we should think through the various GenericErrorTypes anyway.
Note: This has been done for media uploads, which use OkHttpClient directly and don't share the same error reporting as the other endpoints (#505).
The text was updated successfully, but these errors were encountered:
Identify
ConnectException
andUnknownHostException
s inBaseRequest
and report them as a distinct error (notUNKNOWN
) - and float them up toOnChanged
events (instead of reporting asGENERIC_ERROR
).We can get a
ConnectException
when the connection is interrupted while a request is being sent (e.g. turning on airplane mode), and we can get anUnknownHostException
when attemping to make a request while already in airplane mode or lacking a connection.It's possible we might get
UnknownHostException
in other cases as well, so we might not want to identify this one as aNO_CONNECTION
error, but rather as aNETWORK_ERROR
- but we should think through the variousGenericErrorType
s anyway.Note: This has been done for media uploads, which use
OkHttpClient
directly and don't share the same error reporting as the other endpoints (#505).The text was updated successfully, but these errors were encountered: