[Update Detekt Version] Update Detekt to 1.19.0 #16949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 26, 2022
You can test the WordPress changes on this Pull Request by downloading an installable build (wordpress-installable-build-pr16949-65cc613.apk), or scanning this QR code:
|
You can test the Jetpack changes on this Pull Request by downloading an installable build (jetpack-installable-build-pr16949-65cc613.apk), or scanning this QR code:
|
With this update, the configuration for the rules below got updated. Also, one rule, specific to Jetpack Compose, was added: Rules that got updated: - LongParameterList (complexity) - ForbiddenComment (style) Rules that got added: - FunctionNaming (naming) As such, for all the above listed rules, Detekt has started to warn about current violations based on these rule updates. As such those rules need to be updated/added accordingly. This is going to be done in subsequent commits.
With the '1.19.0' Detekt update, the Detekt 'ignoreAnnotated' feature got updated. With that update, the 'javax.inject.Inject' configuration was no longer working and had to be update to its simpler 'Inject' version, which doesn't require the full import naming convention. Also, as part of this update the 'javax.annotation.Generated' or 'Generated' configuration got removed as it is no longer (or was never) necessary. Thus, making this overall configuration much more straightforward.
With the '1.19.0' Detekt update, the Detekt 'values' configuration got updated. With that update, the '['FIXME:', 'STOPSHIP:']' map, although it keeps working as expected, can be update to the list equivalent configuration, which also matches to the 'default-detekt-config.yml' file's configuration. Default Detekt Config: https://github.com/detekt/detekt/blob/main/ detekt-core/src/main/resources/default-detekt-config.yml
This is done in order to ignore the 'Composable' related warning for the 'WordPressTheme' function naming convention. For more info see: https://detekt.dev/docs/introduction/compose
ParaskP7
force-pushed
the
update/detekt-to-1.19.0
branch
from
d993076 to
65cc613
Compare
|
FYI: We can ignore the Buildkite related Instrumented Tests check failing for now. I can merge this to |
oguzkocer
approved these changes
Jul 26, 2022
ovitrif
reviewed
Jul 27, 2022
There was a problem hiding this comment.
Awesome work @ParaskP7!
Thanks a lot for it 🙇 🥇 💯
Now it should theoretically be possible for me to replace UnusedPrivateMember. allowedNames.regex with UnusedPrivateMember. ignoreAnnotated[Preview] ❤️ in the pending Compose PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent: #16892
Closes: #16896
Closes: #16897
This PR:
1.19.0(from1.17.1via1.18.1) (30dff00 + 9bb8c78).PS: I recommend reviewing this PR commit-by-commit.
To test:
detektcheck).Regression Notes
N/A
See
To testsection above.N/A
PR submission checklist:
RELEASE-NOTES.txtif necessary.