Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing connected tests with SiteStore mock. #14922

Merged
merged 3 commits into from
Jun 24, 2021

Conversation

develric
Copy link
Contributor

This is a companion PR for PRthis FluxC and should fix connected tests linked to SiteStore being not mockable.

To test:

Should be enough to trigger optional UI tests and check it's all green.

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@develric develric added this to the 17.7 milestone Jun 24, 2021
@develric develric requested a review from planarvoid June 24, 2021 07:47
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 24, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 24, 2021

You can test the changes on this Pull Request by downloading the APK here.

@develric develric marked this pull request as ready for review June 24, 2021 09:24
Copy link
Contributor

@planarvoid planarvoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! Feel free to merge this once you update the fluxC tag

@develric develric merged commit 2f206a8 into develop Jun 24, 2021
@develric develric deleted the try/fix-site-store-connected-tests branch June 24, 2021 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants