Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GB-mobile to release 1.25.0 #11572

Merged
merged 13 commits into from
Apr 3, 2020

Conversation

SergioEstevao
Copy link
Contributor

Prepare the integration of Gutenberg release 1.25.0

To test:

  • Test the functionality of the Gutenberg editor

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@SergioEstevao SergioEstevao added Gutenberg Editing and display of Gutenberg blocks. gutenberg-mobile labels Apr 1, 2020
@SergioEstevao SergioEstevao added this to the 14.6 milestone Apr 1, 2020
@SergioEstevao SergioEstevao requested review from hypest and etoledom April 1, 2020 09:44
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 1, 2020

You can test the changes on this Pull Request by downloading the APK here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 1, 2020

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@etoledom
Copy link
Contributor

etoledom commented Apr 1, 2020

Writing flow sanity tests:

@etoledom
Copy link
Contributor

etoledom commented Apr 1, 2020

Splittings block tests failures:

TC002 Merge after deleting selection
Video
Following the steps, it breaks trying to merge again the blocks.

@SergioEstevao - This one might be a blocker.

TC004 Merge after deleting all
Video

  • After deleting all text from the second block, the placeholder is not visible.
  • Pressing backspace will show the placeholder.
  • Pressing backspace again will finally merge the block.
  • The cursor appears at the beginning of the block instead of at the end.

Probably not a blocker since it's not critical (just a bit ugly)

@etoledom
Copy link
Contributor

etoledom commented Apr 1, 2020

Multiline components failure:

Caption component is not creating a new line at all.
This happens in Image, Vide, and Gallery blocks.
caption-new-line

@SergioEstevao - This one looks like a pretty bad one too.

@etoledom
Copy link
Contributor

etoledom commented Apr 1, 2020

Rich Text Formatting

TC007 Test format detection under the cursor

This is probably an old one. Gutenberg won't recognise just added strikethrough under the cursor since it uses <del> instead of <s> tags.

EDIT:
Interesting enough, there are times when the <s> tag is used. But when I try many formats together, it will start using <del>.

@etoledom
Copy link
Contributor

etoledom commented Apr 1, 2020

Testing new features:

  • New block: Cover
  • Improve icon on the "Take a Video" media option
  • Removed the dimming effect on unselected blocks
  • Enabled edit button over image block for Android
  • Implemented dropdown toolbar for alignment toolbar in Heading, Paragraph, Image, MediaText blocks
  • When editing link settings, tapping the keyboard return button now closes the settings panel as well as closing the keyboard.

@etoledom
Copy link
Contributor

etoledom commented Apr 1, 2020

None of the issues found are new for this release, so that's a ✅ for the writing flow tests.

@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.
Messages
📖

This PR contains changes in the subtree libs/login/. It is your responsibility to ensure these changes are merged back into wordpress-mobile/WordPress-Login-Flow-Android. Follow these handy steps!
WARNING: Make sure your git version is 2.19.x or lower - there is currently a bug in later versions that will corrupt the subtree history!

  1. cd WordPress-Android
  2. git checkout gutenberg/integrate_release_1.25.0
  3. git subtree push --prefix=libs/login/ https://github.com/wordpress-mobile/WordPress-Login-Flow-Android.git merge/WordPress-Android/11572
  4. Browse to https://github.com/wordpress-mobile/WordPress-Login-Flow-Android/pull/new/merge/WordPress-Android/11572 and open a new PR.

Generated by 🚫 dangerJS

Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SergioEstevao SergioEstevao merged commit 31ef563 into develop Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants