From b00ba72ff6b8d5a77fec46a8751a8085de3d5ed7 Mon Sep 17 00:00:00 2001 From: Joel Dean Date: Tue, 5 Nov 2019 15:04:49 -0800 Subject: [PATCH 01/24] avatar no longer announces "site icon" --- WordPress/src/main/res/layout/reader_cardview_post.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/WordPress/src/main/res/layout/reader_cardview_post.xml b/WordPress/src/main/res/layout/reader_cardview_post.xml index ecd678d4e682..5adb13fe220a 100644 --- a/WordPress/src/main/res/layout/reader_cardview_post.xml +++ b/WordPress/src/main/res/layout/reader_cardview_post.xml @@ -35,7 +35,7 @@ android:layout_centerVertical="true" android:layout_marginEnd="@dimen/reader_card_avatar_margin_end" android:src="@drawable/bg_rectangle_neutral_10_globe_32dp" - android:contentDescription="@string/reader_blavatar_desc" + android:importantForAccessibility="no" style="@style/ReaderImageView.Avatar"> From bc7ca4caa1668dbae52d8de16e369b2513e13562 Mon Sep 17 00:00:00 2001 From: Joel Dean Date: Tue, 5 Nov 2019 16:47:34 -0800 Subject: [PATCH 02/24] Grouped the empty view elements into one so when the user hovers only one layout gets focus. Also the empty state is automatically announced when the view is shown. --- .../wordpress/android/ui/reader/ReaderPostListFragment.java | 3 +++ WordPress/src/main/res/layout/actionable_empty_view.xml | 3 ++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderPostListFragment.java b/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderPostListFragment.java index 0fcf8dd067d1..08ddb79d24af 100644 --- a/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderPostListFragment.java +++ b/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderPostListFragment.java @@ -1375,6 +1375,9 @@ private void setEmptyTitleDescriptionAndButton(@NonNull String title, String des private void showEmptyView() { if (isAdded()) { mActionableEmptyView.setVisibility(View.VISIBLE); + mActionableEmptyView.announceForAccessibility( + String.format("%s... %s", mActionableEmptyView.title.getText(), + mActionableEmptyView.subtitle.getText())); } } diff --git a/WordPress/src/main/res/layout/actionable_empty_view.xml b/WordPress/src/main/res/layout/actionable_empty_view.xml index a45b78c2a4f8..e071b12ef030 100644 --- a/WordPress/src/main/res/layout/actionable_empty_view.xml +++ b/WordPress/src/main/res/layout/actionable_empty_view.xml @@ -11,6 +11,7 @@ android:layout_width="match_parent" > Date: Tue, 5 Nov 2019 17:28:48 -0800 Subject: [PATCH 03/24] The empty view for the FilterRecyclerView now announces it's state. --- .../android/ui/reader/ReaderPostListFragment.java | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderPostListFragment.java b/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderPostListFragment.java index 08ddb79d24af..b496d87ef227 100644 --- a/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderPostListFragment.java +++ b/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderPostListFragment.java @@ -1375,12 +1375,16 @@ private void setEmptyTitleDescriptionAndButton(@NonNull String title, String des private void showEmptyView() { if (isAdded()) { mActionableEmptyView.setVisibility(View.VISIBLE); - mActionableEmptyView.announceForAccessibility( - String.format("%s... %s", mActionableEmptyView.title.getText(), - mActionableEmptyView.subtitle.getText())); + announceEmptyStateForAccessibility(); } } + private void announceEmptyStateForAccessibility() { + mActionableEmptyView.announceForAccessibility( + String.format("%s... %s", mActionableEmptyView.title.getText(), + mActionableEmptyView.subtitle.getText())); + } + private void hideEmptyView() { if (isAdded()) { mActionableEmptyView.setVisibility(View.GONE); From 45e83e497e70ff7805185c293763fe1e4574300d Mon Sep 17 00:00:00 2001 From: Joel Dean Date: Tue, 5 Nov 2019 18:19:12 -0800 Subject: [PATCH 04/24] Fixed save post icon announcement issue The empty view subtitle for the saved posts / bookmarks is built from a span that includes an icon. When TalkBack reads this out it doesn't state what the icon is, so a content description is set and that is utilized instead of the actual text. --- .../android/ui/reader/ReaderPostListFragment.java | 11 ++++++++--- WordPress/src/main/res/values/strings.xml | 1 + 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderPostListFragment.java b/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderPostListFragment.java index b496d87ef227..9f196d73e185 100644 --- a/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderPostListFragment.java +++ b/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderPostListFragment.java @@ -1312,6 +1312,8 @@ private void setEmptyTitleAndDescriptionForBookmarksList() { mActionableEmptyView.image.setVisibility(View.VISIBLE); mActionableEmptyView.title.setText(R.string.reader_empty_saved_posts_title); mActionableEmptyView.subtitle.setText(ssb); + mActionableEmptyView.subtitle + .setContentDescription(getString(R.string.reader_empty_saved_posts_content_description)); mActionableEmptyView.subtitle.setVisibility(View.VISIBLE); mActionableEmptyView.button.setText(R.string.reader_empty_followed_blogs_button_followed); mActionableEmptyView.button.setVisibility(View.VISIBLE); @@ -1380,9 +1382,12 @@ private void showEmptyView() { } private void announceEmptyStateForAccessibility() { - mActionableEmptyView.announceForAccessibility( - String.format("%s... %s", mActionableEmptyView.title.getText(), - mActionableEmptyView.subtitle.getText())); + CharSequence title = mActionableEmptyView.title.getText(); + + CharSequence subTitle = !TextUtils.isEmpty(mActionableEmptyView.subtitle.getContentDescription()) + ? mActionableEmptyView.subtitle.getContentDescription() : mActionableEmptyView.subtitle.getText(); + + mActionableEmptyView.announceForAccessibility(String.format("%s... %s", title, subTitle)); } private void hideEmptyView() { diff --git a/WordPress/src/main/res/values/strings.xml b/WordPress/src/main/res/values/strings.xml index d84f8b3b59ca..f31215b184da 100644 --- a/WordPress/src/main/res/values/strings.xml +++ b/WordPress/src/main/res/values/strings.xml @@ -1689,6 +1689,7 @@ Posts that you like will appear here No posts saved — yet! Tap %s to save a post to your list. + Tap the bookmark icon to save a post to your list. No comments yet This site is empty No results found From b348fe2850349a1d21e77ae965b5554766b8aaa6 Mon Sep 17 00:00:00 2001 From: Joel Dean Date: Wed, 6 Nov 2019 15:19:07 -0800 Subject: [PATCH 05/24] Fixed the text contrast of several views inside the reader layouts. --- WordPress/src/main/res/layout/reader_cardview_post.xml | 2 +- WordPress/src/main/res/layout/reader_site_header_view.xml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/WordPress/src/main/res/layout/reader_cardview_post.xml b/WordPress/src/main/res/layout/reader_cardview_post.xml index 5adb13fe220a..d2b0c30cad61 100644 --- a/WordPress/src/main/res/layout/reader_cardview_post.xml +++ b/WordPress/src/main/res/layout/reader_cardview_post.xml @@ -192,7 +192,7 @@ android:layout_height="wrap_content" android:layout_width="wrap_content" android:maxLines="3" - android:textColor="@color/neutral_30" + android:textColor="@color/neutral_50" android:textSize="@dimen/text_sz_medium" tools:text="text_attribution" style="@style/ReaderTextView" > diff --git a/WordPress/src/main/res/layout/reader_site_header_view.xml b/WordPress/src/main/res/layout/reader_site_header_view.xml index b854655616bd..248c5bae7551 100644 --- a/WordPress/src/main/res/layout/reader_site_header_view.xml +++ b/WordPress/src/main/res/layout/reader_site_header_view.xml @@ -46,7 +46,7 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:layout_below="@+id/text_blog_name" - android:textColor="@color/neutral_40" + android:textColor="@color/neutral_50" android:textSize="@dimen/text_sz_small" tools:text="text_domain" android:layout_toStartOf="@+id/follow_button" @@ -103,7 +103,7 @@ android:id="@+id/text_blog_follow_count" android:layout_width="wrap_content" android:layout_height="wrap_content" - android:textColor="@color/neutral_40" + android:textColor="@color/neutral_50" android:textSize="@dimen/text_sz_small" tools:text="12 followers" /> From f5672e5298a2c1d55809f46c0e25e5b44b166601 Mon Sep 17 00:00:00 2001 From: Joel Dean Date: Thu, 7 Nov 2019 08:50:49 -0800 Subject: [PATCH 06/24] Moved empty state announcement to the empty view itself. --- .../android/ui/ActionableEmptyView.kt | 48 ++++++++++++++++--- .../ui/reader/ReaderPostListFragment.java | 11 +---- 2 files changed, 42 insertions(+), 17 deletions(-) diff --git a/WordPress/src/main/java/org/wordpress/android/ui/ActionableEmptyView.kt b/WordPress/src/main/java/org/wordpress/android/ui/ActionableEmptyView.kt index 1f5a7a79d643..e58500f836a4 100644 --- a/WordPress/src/main/java/org/wordpress/android/ui/ActionableEmptyView.kt +++ b/WordPress/src/main/java/org/wordpress/android/ui/ActionableEmptyView.kt @@ -1,6 +1,7 @@ package org.wordpress.android.ui import android.content.Context +import android.text.TextUtils import android.util.AttributeSet import android.view.Gravity import android.view.View @@ -36,7 +37,11 @@ class ActionableEmptyView : LinearLayout { initView(context, attrs) } - constructor(context: Context, attrs: AttributeSet, defStyle: Int) : super(context, attrs, defStyle) { + constructor(context: Context, attrs: AttributeSet, defStyle: Int) : super( + context, + attrs, + defStyle + ) { initView(context, attrs) } @@ -55,9 +60,17 @@ class ActionableEmptyView : LinearLayout { bottomImage = layout.findViewById(R.id.bottom_image) attrs.let { - val typedArray = context.obtainStyledAttributes(it, R.styleable.ActionableEmptyView, 0, 0) - - val imageResource = typedArray.getResourceId(R.styleable.ActionableEmptyView_aevImage, 0) + val typedArray = context.obtainStyledAttributes( + it, + R.styleable.ActionableEmptyView, + 0, + 0 + ) + + val imageResource = typedArray.getResourceId( + R.styleable.ActionableEmptyView_aevImage, + 0 + ) val titleAttribute = typedArray.getString(R.styleable.ActionableEmptyView_aevTitle) val subtitleAttribute = typedArray.getString(R.styleable.ActionableEmptyView_aevSubtitle) val buttonAttribute = typedArray.getString(R.styleable.ActionableEmptyView_aevButton) @@ -99,17 +112,38 @@ class ActionableEmptyView : LinearLayout { val params: RelativeLayout.LayoutParams if (isSearching) { - params = RelativeLayout.LayoutParams(LayoutParams.MATCH_PARENT, LayoutParams.WRAP_CONTENT) - layout.setPadding(0, context.resources.getDimensionPixelSize(R.dimen.margin_extra_extra_large), 0, 0) + params = RelativeLayout.LayoutParams( + LayoutParams.MATCH_PARENT, + LayoutParams.WRAP_CONTENT + ) + layout.setPadding( + 0, + context.resources.getDimensionPixelSize(R.dimen.margin_extra_extra_large), + 0, + 0 + ) image.visibility = View.GONE button.visibility = View.GONE } else { - params = RelativeLayout.LayoutParams(LayoutParams.MATCH_PARENT, LayoutParams.MATCH_PARENT) + params = RelativeLayout.LayoutParams( + LayoutParams.MATCH_PARENT, + LayoutParams.MATCH_PARENT + ) layout.setPadding(0, 0, 0, 0) } params.topMargin = topMargin layout.layoutParams = params } + + fun announceEmptyStateForAccessibility() { + val subTitle = if (!TextUtils.isEmpty(subtitle.contentDescription)) { + subtitle.contentDescription + } else { + subtitle.text + } + + announceForAccessibility(String.format("%s... %s", title.text, subTitle)) + } } diff --git a/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderPostListFragment.java b/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderPostListFragment.java index 9f196d73e185..74e30ee1a771 100644 --- a/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderPostListFragment.java +++ b/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderPostListFragment.java @@ -1377,19 +1377,10 @@ private void setEmptyTitleDescriptionAndButton(@NonNull String title, String des private void showEmptyView() { if (isAdded()) { mActionableEmptyView.setVisibility(View.VISIBLE); - announceEmptyStateForAccessibility(); + mActionableEmptyView.announceEmptyStateForAccessibility(); } } - private void announceEmptyStateForAccessibility() { - CharSequence title = mActionableEmptyView.title.getText(); - - CharSequence subTitle = !TextUtils.isEmpty(mActionableEmptyView.subtitle.getContentDescription()) - ? mActionableEmptyView.subtitle.getContentDescription() : mActionableEmptyView.subtitle.getText(); - - mActionableEmptyView.announceForAccessibility(String.format("%s... %s", title, subTitle)); - } - private void hideEmptyView() { if (isAdded()) { mActionableEmptyView.setVisibility(View.GONE); From d202317f89c087166137b05cd5ffcd4cdbc91b4b Mon Sep 17 00:00:00 2001 From: Joel Dean Date: Fri, 8 Nov 2019 12:46:06 -0800 Subject: [PATCH 07/24] Simplified string formatting using Kotlin string templates. --- .../main/java/org/wordpress/android/ui/ActionableEmptyView.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/WordPress/src/main/java/org/wordpress/android/ui/ActionableEmptyView.kt b/WordPress/src/main/java/org/wordpress/android/ui/ActionableEmptyView.kt index e58500f836a4..9297946e6324 100644 --- a/WordPress/src/main/java/org/wordpress/android/ui/ActionableEmptyView.kt +++ b/WordPress/src/main/java/org/wordpress/android/ui/ActionableEmptyView.kt @@ -144,6 +144,6 @@ class ActionableEmptyView : LinearLayout { subtitle.text } - announceForAccessibility(String.format("%s... %s", title.text, subTitle)) + announceForAccessibility("${title.text}.$subTitle") } } From 5e1e299ed2854f2dd97a2ad2074689e9d50673d6 Mon Sep 17 00:00:00 2001 From: Joel Dean Date: Fri, 8 Nov 2019 12:49:43 -0800 Subject: [PATCH 08/24] Changed "bookmark icon" to "Add to Save Posts button" for TalkBack consistency Changed the content description of the empty saved post message to "Add to Save Posts button" so it's similar to what's being announced on the post items. --- WordPress/src/main/res/values/strings.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/WordPress/src/main/res/values/strings.xml b/WordPress/src/main/res/values/strings.xml index f31215b184da..7962c4012963 100644 --- a/WordPress/src/main/res/values/strings.xml +++ b/WordPress/src/main/res/values/strings.xml @@ -1689,7 +1689,7 @@ Posts that you like will appear here No posts saved — yet! Tap %s to save a post to your list. - Tap the bookmark icon to save a post to your list. + Tap the Add to Save Posts button to save a post to your list. No comments yet This site is empty No results found From 975d58be5ad970c2893377c4d7e78988edcd190c Mon Sep 17 00:00:00 2001 From: Joel Dean Date: Fri, 8 Nov 2019 13:48:01 -0800 Subject: [PATCH 09/24] "List" announcement no longer happens when the user hovers over the RecyclerView area. --- WordPress/src/main/res/layout/filtered_list_component.xml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/WordPress/src/main/res/layout/filtered_list_component.xml b/WordPress/src/main/res/layout/filtered_list_component.xml index 5aaf59365363..87af67fc91a0 100644 --- a/WordPress/src/main/res/layout/filtered_list_component.xml +++ b/WordPress/src/main/res/layout/filtered_list_component.xml @@ -46,7 +46,9 @@ android:id="@+id/recycler_view" android:layout_width="match_parent" android:layout_height="match_parent" - android:scrollbars="vertical"/> + android:scrollbars="vertical" + android:importantForAccessibility="no" + /> From b190abb4a62c61640d84e7de7c99ba9b90c2e79c Mon Sep 17 00:00:00 2001 From: Joel Dean Date: Fri, 8 Nov 2019 14:37:35 -0800 Subject: [PATCH 10/24] Announce list state when the data is loaded. --- .../android/ui/reader/ReaderPostListFragment.java | 9 ++++++++- WordPress/src/main/res/values/strings.xml | 3 +++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderPostListFragment.java b/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderPostListFragment.java index 74e30ee1a771..4808f75f7627 100644 --- a/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderPostListFragment.java +++ b/WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderPostListFragment.java @@ -1432,6 +1432,7 @@ public void onDataLoaded(boolean isEmpty) { } } else { hideEmptyView(); + announceListStateForAccessibility(); if (mRestorePosition > 0) { AppLog.d(T.READER, "reader post list > restoring position"); mRecyclerView.scrollRecycleViewToPosition(mRestorePosition); @@ -1474,6 +1475,13 @@ && getFragmentManager().findFragmentByTag(tag) == null) { } }; + private void announceListStateForAccessibility() { + if (getView() != null) { + getView().announceForAccessibility(getString(R.string.reader_acessibility_list_loaded, + getPostAdapter().getItemCount())); + } + } + private void showBookmarksSavedLocallyDialog() { mBookmarksSavedLocallyDialog = new AlertDialog.Builder(getActivity()) .setTitle(getString(R.string.reader_save_posts_locally_dialog_title)) @@ -2309,7 +2317,6 @@ public void onScrollToTop() { public static void resetLastUpdateDate() { mLastAutoUpdateDt = null; } - private class LoadTagsTask extends AsyncTask { private final FilteredRecyclerView.FilterCriteriaAsyncLoaderListener mFilterCriteriaLoaderListener; diff --git a/WordPress/src/main/res/values/strings.xml b/WordPress/src/main/res/values/strings.xml index 7962c4012963..efc4b79be9d8 100644 --- a/WordPress/src/main/res/values/strings.xml +++ b/WordPress/src/main/res/values/strings.xml @@ -1555,6 +1555,9 @@ (Untitled) + + "The list has loaded with %1$d items." + WordPress Reader Application log From b24a715f5d905c878d27e72262787df7fe3b2119 Mon Sep 17 00:00:00 2001 From: Joel Dean Date: Fri, 8 Nov 2019 18:50:15 -0800 Subject: [PATCH 11/24] Added TouchDelegate extension method so that the touch area of views can be extended. --- .../org/wordpress/android/util/ViewUtils.kt | 23 +++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/WordPress/src/main/java/org/wordpress/android/util/ViewUtils.kt b/WordPress/src/main/java/org/wordpress/android/util/ViewUtils.kt index 102144cc79bc..23a8e79669f6 100644 --- a/WordPress/src/main/java/org/wordpress/android/util/ViewUtils.kt +++ b/WordPress/src/main/java/org/wordpress/android/util/ViewUtils.kt @@ -1,7 +1,9 @@ package org.wordpress.android.util +import android.graphics.Rect import android.os.Build.VERSION import android.os.Build.VERSION_CODES +import android.view.TouchDelegate import android.view.View fun View.setVisible(visible: Boolean) { @@ -13,3 +15,24 @@ fun View.redirectContextClickToLongPressListener() { this.setOnContextClickListener { it.performLongClick() } } } + + +fun View.expandTouchTargetArea(dps: Int, heightOnly: Boolean = false) { + val pixels = DisplayUtils.dpToPx(context, dps) + val parent = this.parent as View + + parent.post { + val touchTargetRect = Rect() + getHitRect(touchTargetRect) + touchTargetRect.top -= pixels + touchTargetRect.bottom += pixels + + if (!heightOnly) { + touchTargetRect.right += pixels + touchTargetRect.left -= pixels + } + + parent.touchDelegate = TouchDelegate(touchTargetRect, this) + } +} + From f8234a140cd3d695d7a1b6de545a882e4e5eb8dc Mon Sep 17 00:00:00 2001 From: Joel Dean Date: Fri, 8 Nov 2019 19:44:54 -0800 Subject: [PATCH 12/24] Added touch target to follow button to meet accessibility requirements. --- .../android/ui/reader/views/ReaderSiteHeaderView.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/WordPress/src/main/java/org/wordpress/android/ui/reader/views/ReaderSiteHeaderView.java b/WordPress/src/main/java/org/wordpress/android/ui/reader/views/ReaderSiteHeaderView.java index a06b3eebbd2d..9f770679833e 100644 --- a/WordPress/src/main/java/org/wordpress/android/ui/reader/views/ReaderSiteHeaderView.java +++ b/WordPress/src/main/java/org/wordpress/android/ui/reader/views/ReaderSiteHeaderView.java @@ -22,6 +22,7 @@ import org.wordpress.android.util.PhotonUtils.Quality; import org.wordpress.android.util.ToastUtils; import org.wordpress.android.util.UrlUtils; +import org.wordpress.android.util.ViewUtilsKt; import org.wordpress.android.util.image.ImageManager; import org.wordpress.android.util.image.ImageType; @@ -45,6 +46,8 @@ public interface OnBlogInfoLoadedListener { private OnBlogInfoLoadedListener mBlogInfoListener; private OnFollowListener mFollowListener; + private static final int FOLLOW_BUTTON_EXTRA_DPS = 32; + @Inject AccountStore mAccountStore; @Inject ImageManager mImageManager; @@ -66,6 +69,7 @@ public ReaderSiteHeaderView(Context context, AttributeSet attrs, int defStyleAtt private void initView(Context context) { View view = inflate(context, R.layout.reader_site_header_view, this); mFollowButton = view.findViewById(R.id.follow_button); + ViewUtilsKt.expandTouchTargetArea(mFollowButton, FOLLOW_BUTTON_EXTRA_DPS, false); } public void setOnFollowListener(OnFollowListener listener) { From 9e3a6578515517e87fb112e3e07e11ff6ed2b341 Mon Sep 17 00:00:00 2001 From: Joel Dean Date: Fri, 8 Nov 2019 19:53:46 -0800 Subject: [PATCH 13/24] Added touch target to discover and visit layout to meet accessibility requirements. --- .../android/ui/reader/adapters/ReaderPostAdapter.java | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/WordPress/src/main/java/org/wordpress/android/ui/reader/adapters/ReaderPostAdapter.java b/WordPress/src/main/java/org/wordpress/android/ui/reader/adapters/ReaderPostAdapter.java index ca8d2b6731c9..ea977be1d083 100644 --- a/WordPress/src/main/java/org/wordpress/android/ui/reader/adapters/ReaderPostAdapter.java +++ b/WordPress/src/main/java/org/wordpress/android/ui/reader/adapters/ReaderPostAdapter.java @@ -66,6 +66,7 @@ import org.wordpress.android.util.GravatarUtils; import org.wordpress.android.util.NetworkUtils; import org.wordpress.android.util.ToastUtils; +import org.wordpress.android.util.ViewUtilsKt; import org.wordpress.android.util.analytics.AnalyticsUtils; import org.wordpress.android.util.image.ImageManager; import org.wordpress.android.util.image.ImageType; @@ -122,6 +123,9 @@ public class ReaderPostAdapter extends RecyclerView.Adapter Date: Fri, 8 Nov 2019 20:05:15 -0800 Subject: [PATCH 14/24] Added touch target sizing to more menu button to meet accessibility requirements. --- .../wordpress/android/ui/reader/adapters/ReaderPostAdapter.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/WordPress/src/main/java/org/wordpress/android/ui/reader/adapters/ReaderPostAdapter.java b/WordPress/src/main/java/org/wordpress/android/ui/reader/adapters/ReaderPostAdapter.java index ea977be1d083..09ca4d64c76a 100644 --- a/WordPress/src/main/java/org/wordpress/android/ui/reader/adapters/ReaderPostAdapter.java +++ b/WordPress/src/main/java/org/wordpress/android/ui/reader/adapters/ReaderPostAdapter.java @@ -125,6 +125,7 @@ public class ReaderPostAdapter extends RecyclerView.Adapter Date: Fri, 8 Nov 2019 20:10:56 -0800 Subject: [PATCH 15/24] Added touch target to filter spinner to meet accessibility requirements. --- WordPress/src/main/res/layout/filtered_list_component.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/WordPress/src/main/res/layout/filtered_list_component.xml b/WordPress/src/main/res/layout/filtered_list_component.xml index 87af67fc91a0..4c555cf54a2c 100644 --- a/WordPress/src/main/res/layout/filtered_list_component.xml +++ b/WordPress/src/main/res/layout/filtered_list_component.xml @@ -24,6 +24,7 @@ android:id="@+id/filter_spinner" style="@style/FilteredRecyclerViewSpinner.WordPress" android:layout_width="wrap_content" + android:minHeight="@dimen/min_touch_target_sz" android:layout_height="wrap_content" android:overlapAnchor="false" tools:ignore="UnusedAttribute"/> From 812a642196a986eb089b9d16e0e548e55f30d73e Mon Sep 17 00:00:00 2001 From: Joel Dean Date: Fri, 8 Nov 2019 20:47:49 -0800 Subject: [PATCH 16/24] Removed unnecessary blank line. --- WordPress/src/main/java/org/wordpress/android/util/ViewUtils.kt | 1 - 1 file changed, 1 deletion(-) diff --git a/WordPress/src/main/java/org/wordpress/android/util/ViewUtils.kt b/WordPress/src/main/java/org/wordpress/android/util/ViewUtils.kt index 23a8e79669f6..9a070cbdbef1 100644 --- a/WordPress/src/main/java/org/wordpress/android/util/ViewUtils.kt +++ b/WordPress/src/main/java/org/wordpress/android/util/ViewUtils.kt @@ -16,7 +16,6 @@ fun View.redirectContextClickToLongPressListener() { } } - fun View.expandTouchTargetArea(dps: Int, heightOnly: Boolean = false) { val pixels = DisplayUtils.dpToPx(context, dps) val parent = this.parent as View From 94ad7ffd98d51b6b3a9485f12286e400beccc666 Mon Sep 17 00:00:00 2001 From: Joel Dean Date: Fri, 8 Nov 2019 21:33:02 -0800 Subject: [PATCH 17/24] Changed text contrast of tag edit text style. --- WordPress/src/main/res/values/reader_styles.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/WordPress/src/main/res/values/reader_styles.xml b/WordPress/src/main/res/values/reader_styles.xml index 6316defa36fa..0e78294c697d 100644 --- a/WordPress/src/main/res/values/reader_styles.xml +++ b/WordPress/src/main/res/values/reader_styles.xml @@ -62,7 +62,7 @@