Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Error Messaging for Invalid URLs - Take 2 #9720

Closed
diegoreymendez opened this issue Apr 25, 2019 · 4 comments · Fixed by #10255
Closed

Better Error Messaging for Invalid URLs - Take 2 #9720

diegoreymendez opened this issue Apr 25, 2019 · 4 comments · Fixed by #10255

Comments

@diegoreymendez
Copy link

Description

This is a follow up to #8460

This feature has been enhanced for WPiOS beyond the initial solution proposed above.

The URL validation is now triggered by the user typing, and the "Next" button is not enabled until a valid URL is detected.

The URL validation error (pending editorial review) was changed to:

Enter a valid URL eg. example.com.

iOS Demo:

Here's the iOS demo of the enhanced feature:

invalidURL

@designsimply
Copy link
Contributor

Moving up in priority because it was already updated in WPiOS and we want the experience across platforms to be consistent when possible.

@shiki shiki self-assigned this Jul 19, 2019
@shiki
Copy link
Member

shiki commented Jul 19, 2019

@diegoreymendez When I checked iOS, it looks like this plan has since been reverted after the fixes for wordpress-mobile/WordPress-iOS#11617. On iOS, I can enter "oneword" and the Next button is immediately enabled. Is this plan still valid?

@diegoreymendez
Copy link
Author

diegoreymendez commented Jul 19, 2019

It wasn't entirely rolled back. The "Next" button is still disabled in some scenarios where the URL is clearly wrong, but the domain validation is much more forgiving than it was at first.

If you want to see this in action, try typing "%%%%" in the domain name: the "Next" button will be disabled and you'll see an error message beneath the input field.

I'm not sure this should be higher priority though, as the domain verification is so forgiving that it's hard to see it in action. My 2 cents.

@shiki
Copy link
Member

shiki commented Jul 19, 2019

@diegoreymendez Thank you! I'll try to implement it to be less forgiving and test the regressions that were brought up on iOS.

I'm not sure this should be higher priority though

I picked it up because it was close to the top in the Groundskeeping prioritized board and I thought I could finish it before my rotation is up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants