-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better Error Messaging for Invalid URLs - Take 2 #9720
Comments
Moving up in priority because it was already updated in WPiOS and we want the experience across platforms to be consistent when possible. |
@diegoreymendez When I checked iOS, it looks like this plan has since been reverted after the fixes for wordpress-mobile/WordPress-iOS#11617. On iOS, I can enter "oneword" and the Next button is immediately enabled. Is this plan still valid? |
It wasn't entirely rolled back. The "Next" button is still disabled in some scenarios where the URL is clearly wrong, but the domain validation is much more forgiving than it was at first. If you want to see this in action, try typing "%%%%" in the domain name: the "Next" button will be disabled and you'll see an error message beneath the input field. I'm not sure this should be higher priority though, as the domain verification is so forgiving that it's hard to see it in action. My 2 cents. |
@diegoreymendez Thank you! I'll try to implement it to be less forgiving and test the regressions that were brought up on iOS.
I picked it up because it was close to the top in the Groundskeeping prioritized board and I thought I could finish it before my rotation is up. |
Description
This is a follow up to #8460
This feature has been enhanced for WPiOS beyond the initial solution proposed above.
The URL validation is now triggered by the user typing, and the "Next" button is not enabled until a valid URL is detected.
The URL validation error (pending editorial review) was changed to:
iOS Demo:
Here's the iOS demo of the enhanced feature:
The text was updated successfully, but these errors were encountered: