-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customizer: Auto-sign into system WebView when launching Customize WebView from system browser #5077
Comments
A couple users have left negative app reviews, remarking on the recent change that opens the customizer in the browser. Authenticating that view for the user might help this feel less disruptive. |
In my case, I was prompted to login into |
I was able to login to Although, I also found out that I could more easily access the Customizer from within the app, which is convenient but the path to it much less intuitive (considering there's already the more obvious Customize button on the Themes screen):
Tested on S7 Edge, 7.4-rc-2. |
This came up again in testing feedback (internal ref: pxLjZ-50u-p2). I'm not sure how much work it would be to implement this, so I've added it to the groundskeeping project — if it can't be done during groundskeeping I'd like to at least work out how much effort it would take. |
Noting a recent three star review:
|
Feedback from a three star review:
|
Webviews often have problems with interactions such as sharing or likes or comments. Would the Customizer be usable from within a webview? Note: I moved this issue to the |
@designsimply I think for clarity we should retain the original title on this issue ("Auto-sign into system WebView when launching Customize WebView from system browser"). The changes from #4934 and #5071 were specifically to launch the Customizer in the system browser, not an app webview, because there were problems with the Customizer's features not all working in the app webview. This is a followup issue to try auto-authenticating the user in the system browser, to make that flow from the app to the browser smoother (so users don't have to log in again). |
I have been thinking about a solution for this task. I haven't came up with a secure simple solution. I think we have the following options
If the user opened the system browser app in the following 3 minutes they'd still be surprised to see they are logged in, but the security risks would be definitely way lower and probably acceptable. We could even invalidate the token from the app when the user leaves the customizer. All in all, I can't think of a simple solution. Solution number |
At this point I'd recommend the first option:
Given that there isn't a simple solution here and we're already working on a Gutenberg site editing experience, it makes sense to keep the project focus on Gutenberg and let the current customizer continue as it is. Especially since this isn't a blocker to using the customizer (it just requires logging in to the same account in the browser that you're logged into in the app). |
I completely agree it makes sense to keep it as it is -> Closing as won't fix. |
Context: Refer to #4934 and #5071 for discussion.
Expected behavior
Since the user is signed in on the app already we should be able to authenticate automatically when launching a WebView, but the user is prompted for their credentials when the system WebView is launched.
Steps to reproduce the behavior
Customize
Tested on Pixel (API 24), Genymotion (API 16/23)
The text was updated successfully, but these errors were encountered: