Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics Audit #4245

Closed
sendhil opened this issue Jun 17, 2016 · 10 comments
Closed

Analytics Audit #4245

sendhil opened this issue Jun 17, 2016 · 10 comments

Comments

@sendhil
Copy link
Contributor

sendhil commented Jun 17, 2016

Let's perform an Analytics Audit as it's been a while. We should check for redundant events, consistency, and add in any missing events.

@sendhil
Copy link
Contributor Author

sendhil commented Jun 17, 2016

Parallel WPiOS Issue - wordpress-mobile/WordPress-iOS#5581

@sendhil sendhil added this to the High Priority milestone Jun 20, 2016
@maxme
Copy link
Contributor

maxme commented Jun 28, 2016

dotcom_user metadata is not set correctly (based on isSignedIn:

public static boolean isSignedIn() {
return getDefaultAccount().hasAccessToken() || (WordPress.wpDB.getNumVisibleBlogs() != 0);
}
)

@aforcier
Copy link
Contributor

^ dotcom_user is also not being sent to Tracks at the moment, only to Mixpanel.

@kwonye
Copy link
Contributor

kwonye commented Jul 11, 2016

Also, can we add Helpshift auditing to this please? I know there are a lot of things we can send as Helpshift metadata to help out our Happiness Engineers cc @rachelmcr

@maxme
Copy link
Contributor

maxme commented Jan 2, 2017

Adding some related issues here:

@designsimply
Copy link
Contributor

Added to Prioritized Android Groundskeeping to ask for a refresh of this issue during a future maintenance rotation. I noticed the two linked issues in the most recent prior comment were both auto-closed by stalebot some time ago.

Can both of the issues, #4199 and #4088, please be re-checked and re-opened if they are still valid?

Can this issue please be updated with more specific instructions or can new issues be created that are more up-to-date compared to this issue?

@planarvoid
Copy link
Contributor

This is really hard to do since there are no specs for what we should be tracking and I can't really read the iOS code. Would it be possible to split this into separate steps. Like defining the tracking events and when they should be sent for all the components and making sure they are sent correctly on both platforms? This sounds like a project out of groundskeeping scope but I think it's the correct approach. I can't really validate the two issues without someone from iOS specifying what's being sent on these platforms.

@designsimply
Copy link
Contributor

@bummytime may we have your input on prioritization for this one? Should the [Pri] High label remain or be removed?

@designsimply
Copy link
Contributor

I removed the high priority label from this issue due to inactivity and removed it from the Groundskeeping project because we reviewed it twice in two separate rotations and received feedback that it would be helpful to break the task down into smaller, more manageable steps. 🙏

Please feel free to move this back into Groundskeeping after adding some additional, more specific direction (a checklist perhaps?) or to close the issue in favor of re-assessing analytics at a later date if that's preferable. Thanks! cc @bummytime

@bummytime
Copy link
Member

@designsimply thank you for updating this issue. From my perspective, this is a nebulous request that we are always addressing as we ship features. Soooo, I am going to close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants