Proposition: Migrate local drafts to drafts status

[maxme]

This is a discussion ticket.

Proposition

In the next version upgrade (12.9 -> 13.0?), override status of local drafts (and only local drafts), from Publish to Draft. Don't change status if different from Publish.

Why

• Prior to this PR Make new Posts status draft by default #9322 (version 12.0) - new posts were created with the "Publish" status as default status.
• Since we started to auto upload local drafts, this caused an issue with local draft being automatically uploaded.

By migrating local drafts, and forcing the status to Draft, this will fix future issue of this kind.

cc @wordpress-mobile/ravenclaw

[malinajirka]

Just a few notes:

• If the user clicks on "Publish" and the upload fails, I believe we create a local draft with "Publish" status. If we migrate even these posts, when the user clicks on "Retry", the post won't be published and will be uploaded to the server as a draft. I'm a bit concerned it might be confusing to change this behavior just for one release and then changing it back. We might want to consider migrating only posts which have lastModified older than a certain date.
• Another thing I'd consider is using the same approach for private, pending and scheduled statuses. I realize those were never default, but if the users were used to keeping them as local drafts, they might still be surprised if some old posts/pages will get published.

Wdyt?

[shiki]

With the proposed plan in paCBwp-c7-p2, I don't think we need to do this anymore. That is because local drafts with PUBLISHED status will no longer be automatically uploaded unless the user has explicitly confirmed it.

	LOCAL DRAFT Status	User confirmed intent to publish?	Action
q	DRAFT	n/a	auto-upload
r	PUBLISHED	❌	ignore
s	PUBLISHED	✔️	auto-upload

Note that for (s), we cannot do this with the auto-uploader yet. We're working on that in #10174 (comment). For now, users can publish these local drafts by manually clicking the Publish button while online.

Explicit confirmation is being discussed in #10021.

[malinajirka]

I'm closing this ticket as all local drafts with un-confirmed changes are uploaded as Drafts -

WordPress-Android/WordPress/src/main/java/org/wordpress/android/ui/uploads/PostUploadHandler.java

Line 277 in 1a3fb61

mPost.setStatus(PostStatus.DRAFT.toString());