Editor: wrong message in progress dialog while discarding local changes

[develric]

For simplicity we will refer only to Posts in the following description, but the issue applies both to Posts and Pages and it's not dependent on the editor (Aztec or GB) used.

Expected behavior

While editing an existing Post (Published, Draft, Scheduled or Trashed), we get the possibility to discard the local changes using the “Discard Local Changes” menu item in the Editor overflow menu. Selecting to discard the local changes we should get a Progress Dialog with the message “Discarding local changes”.

Actual behavior

During discarding operation, we get the message “Loading revision”.

Steps to reproduce the behavior

1. From the Posts list select a category (Published, Draft, Scheduled or Trashed),
2. Choose to Edit an existing post from the selected category
3. Make some editing
4. Select the “Discard Local Changes” menu item from the overflow menu
5. Observe the “Loading revision” message in the Progress Dialog

Tested on [Xiaomi Redmi Note 5], Android [8.1.0], WPAndroid [alpha-172]

Some analysis done

Here the flag mIsDiscardingChanges = true; is set after the call to showDialogProgress(true);. Should be enough to swap their order to make the trick.

[develric]

PR #10085 should fix this issue as a side effect.

[maxme]

FWIW, we're going to drop the "Discard Local Changes" feature soon: #9561

[oguzkocer]

It looks like "Discard Local Changes" was indeed dropped. Closing this issue.