From 5b4695f0ce5b5edd9af1223f6586973f0ad53249 Mon Sep 17 00:00:00 2001 From: Olivier Halligon Date: Fri, 1 Apr 2022 20:33:56 +0200 Subject: [PATCH] TODO to remove `android_create_xml_release_notes` Now that this is automated via fastlane supply (aka `upload_to_play_store` during the `upload_build_to_play_store` lane, we should not be needing this anymore. Keeping it for a couple of sprints still just in case as a fallback, until we validate with a couple of releases that the new way works without any issue, but we should delete that in a release or two once the new way has made its proofs. --- fastlane/Fastfile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fastlane/Fastfile b/fastlane/Fastfile index 3cc345b31c21..3b0f9feaf330 100644 --- a/fastlane/Fastfile +++ b/fastlane/Fastfile @@ -718,6 +718,7 @@ REPOSITORY_NAME = 'WordPress-Android' download_path: download_path ) + # TODO: Remove this call after a few sprints of validating that that the `skip_upload_metadata: options[:track] != 'production'` recently added to `upload_build_to_play_store` lane works well android_create_xml_release_notes(download_path: download_path, build_number: "#{options[:build_number]}", locales: RELEASE_NOTES_LOCALES) sh("git add #{download_path} && git commit -m \"Update WordPress metadata translations for #{options[:version]}\" && git push origin HEAD") end @@ -752,6 +753,7 @@ REPOSITORY_NAME = 'WordPress-Android' File.join(download_path, 'en-US') ) + # TODO: Remove this call after a few sprints of validating that that the `skip_upload_metadata: options[:track] != 'production'` recently added to `upload_build_to_play_store` lane works well locales_including_enUS = [['en-gb', 'en-US']] + JP_RELEASE_NOTES_LOCALES # first item (GlotPress locale) unused for this action; second param = google_play locale android_create_xml_release_notes(download_path: download_path, build_number: "#{options[:build_number]}", locales: locales_including_enUS) sh("git add #{download_path} && git commit -m \"Update Jetpack metadata translations for #{options[:version]}\" && git push origin HEAD")