Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merging classes with same api path can cause with model resolution #560

Closed
fehguy opened this issue May 13, 2014 · 4 comments
Closed

merging classes with same api path can cause with model resolution #560

fehguy opened this issue May 13, 2014 · 4 comments

Comments

@fehguy
Copy link
Contributor

fehguy commented May 13, 2014

if you have two classes pointing to the same @Api path, you may have models unable to resolve. Create a class with /v1 as the path with one model as a response type, and another class with the same @Api path. The models may not resolve correctly from one or the other classes.

@pikazlou
Copy link

Fixing this issue is important for me. Can you give some thoughts about the class responsible for it. I can then try to fix it.

@pikazlou
Copy link

I fixed and checked this issue in my fork of master (1.3.5) branch.
Here is the patch: https://gist.github.com/pikazlou/4d75f0a9aefbd3151011
generated with 'git format-patch -1 ...'
Please note, I have zero experience with scala, so my patch can be improved.

@fehguy
Copy link
Contributor Author

fehguy commented May 16, 2014

Great! Can you send a pull request to the develop branch here?

@fehguy
Copy link
Contributor Author

fehguy commented Jun 16, 2014

This should be fixed in 1.3.6

@fehguy fehguy closed this as completed Jun 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants