Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] Question 패키지를 Template 하위로 이동 #956

Merged
merged 2 commits into from
Nov 5, 2024
Merged

[BE] Question 패키지를 Template 하위로 이동 #956

merged 2 commits into from
Nov 5, 2024

Conversation

donghoony
Copy link
Contributor

🚀 어떤 기능을 구현했나요 ?

🔥 어떻게 해결했나요 ?

  • Question 안에 있는 클래스를 Template으로 이동했습니다~

@donghoony
refactor: Question 도메인을 Template 아래로 이동
8d03541 
- 전체적인 경계를 아래와 같이 나눔:
1. 템플릿 (질문, 옵션, 섹션, 템플릿)
2. 리뷰 (답변)
3. 하이라이트
4. 리뷰그
@donghoony
refactor: TemplateService에서 리뷰 그룹 Repository 계층을 참조하지 않도록 수정
259d2ac
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024

Test Results

154 tests   151 ✅  4s ⏱️
 59 suites    3 💤
 59 files      0 ❌

Results for commit 259d2ac.

nayonsoso
nayonsoso approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@nayonsoso nayonsoso left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

도메인의 변경 경계에 따라서 패키지를 잘 이동해주었네요👍👍

Kimprodp
Kimprodp approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@Kimprodp Kimprodp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빠른 작업 👍

void 잘못된_리뷰_요청_코드로_리뷰_작성폼을_요청할_경우_예외가_발생한다() {
문제가 많았던 부분..

skylar1220
skylar1220 approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@skylar1220 skylar1220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

@donghoony donghoony merged commit cfdaeac into develop Nov 5, 2024
6 checks passed
@donghoony donghoony self-assigned this Nov 17, 2024
@donghoony donghoony deleted the be/refactor/domain-package branch November 17, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kimprodp Kimprodp Kimprodp approved these changes

@skylar1220 skylar1220 skylar1220 approved these changes

@nayonsoso nayonsoso nayonsoso approved these changes

Assignees

@donghoony donghoony

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@donghoony @nayonsoso @skylar1220 @Kimprodp