Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

번들 사이즈 최적화 #466

Merged
merged 9 commits into from
Sep 20, 2023
Merged

번들 사이즈 최적화 #466

merged 9 commits into from
Sep 20, 2023

Conversation

solo5star
Copy link
Member

#️⃣ 연관된 이슈

close #439

📝 작업 내용

  • 번들 사이즈를 최적화하였습니다. (600KB -> 약 250KB)
  • 라우트 단위의 lazy loading 적용
  • logo 글자를 svg로 렌더링하여 용량 최적화
  • msw를 번들링에서 제외하도록 설정
  • Page postfix 리팩토링
  • onClick 이벤트를 a 태그로 변경

💬 리뷰 요구사항

@solo5star solo5star added FE 될 때까지 한다잉 우선순위:🟠높음 비교적 먼저 작업해야 합니다. 카테고리:리팩토링🪚 리팩토링입니다. 카테고리:최적화🚀 성능 최적화와 연관된 이슈입니다. labels Sep 20, 2023
@solo5star solo5star self-assigned this Sep 20, 2023
jeongwusi
jeongwusi approved these changes Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@jeongwusi jeongwusi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿

@solo5star solo5star merged commit 1775c47 into main Sep 20, 2023
@solo5star solo5star deleted the feat/439-bundle-size-optimization branch September 20, 2023 13:31
@solo5star solo5star linked an issue Sep 28, 2023 that may be closed by this pull request
페이지 컴포넌트는 ~~Page suffix를 붙이는게 어떨까요? #344
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeongwusi jeongwusi jeongwusi approved these changes

@geuntaek1013 geuntaek1013 Awaiting requested review from geuntaek1013 geuntaek1013 is a code owner

Assignees

@solo5star solo5star

Labels
FE 될 때까지 한다잉 우선순위:🟠높음 비교적 먼저 작업해야 합니다. 카테고리:리팩토링🪚 리팩토링입니다. 카테고리:최적화🚀 성능 최적화와 연관된 이슈입니다.
Projects
2023-yozm-cafe
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

로딩 성능 최적화 페이지 컴포넌트는 ~~Page suffix를 붙이는게 어떨까요?
2 participants
@solo5star @jeongwusi