Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] api 모킹을 제거한다. #748

Merged

Conversation

dayelop
Copy link
Collaborator

@dayelop dayelop commented Oct 10, 2022

  • 🔀 PR 제목의 형식을 잘 작성했나요? e.g. [feat] PR을 등록한다.
  • 💯 테스트는 잘 통과했나요?
  • 🏗️ 빌드는 성공했나요?
  • 🧹 불필요한 코드는 제거했나요?
  • 💭 이슈는 등록했나요?
  • 🏷️ 라벨은 등록했나요?
  • 💻 git rebase를 사용했나요?
  • 🌈 알록달록한가요?

작업 내용

  • 패키지 제거
  • index.tsx
  • public/mockServiceWorker.js
  • src/mocks

주의사항

develop 서버로 개발을 진행하고 있어 모킹을 사용하는 일이 없기 때문에 관련 코드를 모두 제거하기로 하였습니다
조금 더 가벼운 달록 프론트엔드 코드를 위해~!
모킹 잘 가 👋🏻

Closes #747

@dayelop dayelop added frontend 프론트엔드 refactor 리팩터링 labels Oct 10, 2022
@dayelop dayelop requested a review from jhy979 October 10, 2022 05:24
@dayelop dayelop self-assigned this Oct 10, 2022
@dayelop dayelop linked an issue Oct 10, 2022 that may be closed by this pull request
4 tasks
Copy link
Collaborator

@jhy979 jhy979 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

모킹 고마웠어 잘가~✋✋

@dayelop dayelop merged commit 47725c4 into woowacourse-teams:develop Oct 10, 2022
@hyeonic hyeonic mentioned this pull request Oct 19, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend 프론트엔드 refactor 리팩터링
Projects
None yet
Development

Successfully merging this pull request may close these issues.

api 모킹을 제거한다.
2 participants