[feat] 일정 추가/수정 시 카테고리 선택 목록을 편집가능 목록으로 변경한다. #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dayelop
reviewed
Oct 9, 2022
| categoryId: scheduleInfo.categoryId, | ||
| }); | ||
|
|
||
| const { data: editableCategoryGetResponse } = useGetEditableCategories({ enabled: isSuccess }); |
There was a problem hiding this comment.
single category 조회가 성공한 후에 요청하는 이유가 뭔가요?! 😮
There was a problem hiding this comment.
아 아까 디스코드에서 말씀드릭 부분떄문에 조금 헷갈렸떤 것 같아요.
동기 에러인줄 알았었는데.. ㅠㅠ 다시돌리겠습니다
- 구글 카테고리도 편집가능한 카테고리로 들어오더라구요? 구글 일정들은 수정 불가능하니깐 필터링 진행했어요.
🔨 1c63cbe
jhy979
force-pushed
the
feature/737-edit-schedule-category
branch
from
35cb362
to
1c63cbe
Compare
jhy979
force-pushed
the
feature/737-edit-schedule-category
branch
from
1c63cbe
to
a2680b7
Compare
dayelop
requested changes
Oct 9, 2022
| (scheduleInfo.categoryType === CATEGORY_TYPE.NORMAL || | ||
| scheduleInfo.categoryType === CATEGORY_TYPE.PERSONAL) && | ||
| user.id === categoryGetResponse?.data.creator.id; | ||
| const canEditSchedule = editableCategoryGetResponse?.data.find( |
There was a problem hiding this comment.
canEditSchedule이 boolean 값으로 사용되고 있으니 some을 사용하는 건 어떨까요~!
jhy979
force-pushed
the
feature/737-edit-schedule-category
branch
from
6576704
to
808394b
Compare
dayelop
approved these changes
Oct 9, 2022
|
커밋이 이정도로 간단하면 돌려서 하나로 합쳐버리자고 생각하고 한 번 해봤는데 더 귀찮네요 ㅋㅋ 다음엔 그냥 하려구요! |
jhy979
force-pushed
the
feature/737-edit-schedule-category
branch
from
808394b
to
5a6b66c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[feat] PR을 등록한다.작업 내용
일정 추가/수정 시 카테고리 선택 목록을 편집가능 목록으로 변경한다.
Closes #737