Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] 불필요한 디렉토리를 제거한다. #602

Merged
merged 1 commit into from
Sep 18, 2022

Conversation

devHudi
Copy link
Collaborator

@devHudi devHudi commented Sep 18, 2022

  • 🔀 PR 제목의 형식을 잘 작성했나요? e.g. [feat] PR을 등록한다.
  • 💯 테스트는 잘 통과했나요?
  • 🏗️ 빌드는 성공했나요?
  • 🧹 불필요한 코드는 제거했나요?
  • 💭 이슈는 등록했나요?
  • 🏷️ 라벨은 등록했나요?
  • 💻 git rebase를 사용했나요?
  • 🌈 알록달록한가요?

작업 내용

이 디렉토리가 꽤 예전부터 올라와있던데, 왜 올라와있는지 모르겠네요 😅
디렉토리 이름이 ~ 로 시작해서 IDE에서는 안보였던 것 같습니다.

스크린샷

주의사항

Closes #601

Copy link
Collaborator

@hyeonic hyeonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아 이게 불필요한 파일 이었군요..ㅎ ㅋㅋㅋㅋㅋㅋㅋㅋ jacoco할 때 필요한 파일 인줄.. 바로 Approve 합니다!

@devHudi
Copy link
Collaborator Author

devHudi commented Sep 18, 2022

아 이게 불필요한 파일 이었군요..ㅎ ㅋㅋㅋㅋㅋㅋㅋㅋ jacoco할 때 필요한 파일 인줄.. 바로 Approve 합니다!

ㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋ 좀 웃기네요 ㅋㅋㅋ

@github-actions
Copy link

Test Results

  41 files    41 suites   14s ⏱️
255 tests 255 ✔️ 0 💤 0
281 runs  281 ✔️ 0 💤 0

Results for commit cbea24c.

Copy link
Collaborator

@summerlunaa summerlunaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

머야 있는지도 몰랐네 ㅋㅋ approve.

@devHudi devHudi merged commit 8cb9f48 into develop Sep 18, 2022
@summerlunaa summerlunaa deleted the feature/601-remove-dir branch September 21, 2022 05:59
@hyeonic hyeonic mentioned this pull request Sep 22, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants