Skip to content
This repository has been archived by the owner on Dec 5, 2024. It is now read-only.

False positive results when running Bootstrapper #19

Open
Larusso opened this issue Oct 9, 2017 · 2 comments
Open

False positive results when running Bootstrapper #19

Larusso opened this issue Oct 9, 2017 · 2 comments
Assignees
Labels

Comments

@Larusso
Copy link
Member

Larusso commented Oct 9, 2017

The Bootstrapper fails only with exit code -1 if the to be downloaded program file doesn't exist.
In case of IO errors with corrupted files means we have a false positive.

catch (Exception exn)
{
if (!File.Exists(target))
Environment.ExitCode = 1;
var oldColor = Console.ForegroundColor;
Console.ForegroundColor = ConsoleColor.Red;
Console.WriteLine(exn.Message);
Console.ForegroundColor = oldColor;

We should check the file checksum with the value provided by github.

@marcolink
Copy link

@Larusso should we close it? 😄

@Larusso
Copy link
Member Author

Larusso commented Feb 6, 2024

Well it's been a while haha

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants