Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build multiarch images for server #821

Merged
merged 31 commits into from
Mar 1, 2022
Merged

Build multiarch images for server #821

merged 31 commits into from
Mar 1, 2022

Conversation

relnod
Copy link
Contributor

@relnod relnod commented Mar 1, 2022 •
edited
Loading

Continuing #785 and #635

The handling of arm/v7 and arm64/v8 is realy weird as xgo and docker buildx use them differently.

I tested it manually in the following way:

$ docker run -w /src -v `pwd`:/src -it --rm --entrypoint "/bin/bash" techknowlogick/xgo
$ apt update
$ apt install tree
$ PLATFORMS="linux|arm64/v8;linux|arm/v7;linux|amd64" make cross-compile-server
$ exit
$ docker buildx build -f docker/Dockerfile.server.multiarch --platform="linux/amd64" -t woodpecker-server .
$ docker buildx build -f docker/Dockerfile.server.multiarch --platform="linux/arm/v7" -t woodpecker-server .
$ docker buildx build -f docker/Dockerfile.server.multiarch --platform="linux/arm64/v8" -t woodpecker-server .

This could be simplified further, but I first want to see if the pipeline works.

6543 and others added 28 commits December 21, 2021 06:12
@anbraten anbraten mentioned this pull request Mar 1, 2022
Closed
@anbraten
Copy link
Member

anbraten commented Mar 1, 2022

@relnod Looks like a success 😉

@6543 6543 added build CI pipeline related feature add new functionality server labels Mar 1, 2022
@6543
Copy link
Member

6543 commented Mar 1, 2022

This could be simplified further, but I first want to see if the pipeline works.

it works ... it stays this way ... we can play around in upcoming pulls 👍

anbraten
anbraten approved these changes Mar 1, 2022
View reviewed changes
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@anbraten anbraten changed the title Multiarch build server Build multiarch images for server Mar 1, 2022
@anbraten anbraten enabled auto-merge (squash) March 1, 2022 15:29
@anbraten anbraten merged commit da99f47 into woodpecker-ci:master Mar 1, 2022
@6543 6543 mentioned this pull request Mar 1, 2022
Closed
@6543 6543 added this to the 1.0.0 milestone Mar 1, 2022
@6543 6543 mentioned this pull request Mar 1, 2022
Closed
6543 added a commit to 6543-forks/woodpecker that referenced this pull request Mar 1, 2022
@relnod @6543 @anbraten
Build multiarch images for server (woodpecker-ci#821)
2046b84 
Co-authored-by: 6543 <[email protected]>
Co-authored-by: Anbraten <[email protected]>
@6543 6543 mentioned this pull request Mar 1, 2022
Merged
@relnod relnod deleted the multiarch-build-server branch March 1, 2022 17:11
@relnod
Copy link
Contributor Author

relnod commented Mar 1, 2022

Nice! Thanks for merging so quickly and for the initial work!

6543 added a commit that referenced this pull request Mar 2, 2022
@6543 @anbraten @relnod
Build multiarch images for server (#821) (#822)
caa3409 
Co-authored-by: 6543 <[email protected]>
Co-authored-by: Anbraten <[email protected]>
Co-authored-by: relnod <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@6543 6543 6543 approved these changes

@anbraten anbraten anbraten approved these changes

Assignees
No one assigned
Labels
build CI pipeline related feature add new functionality server
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@relnod @anbraten @6543