Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for building in docker #759

Merged
merged 13 commits into from
Feb 10, 2022

Conversation

LamaAni
Copy link
Contributor

@LamaAni LamaAni commented Feb 8, 2022

As a developer I would like to build woodpecker on any environment

Added:

  1. Make command to build woodpecker on docker (recreate make build environment).
  2. Dockerfile for make environment

@LamaAni LamaAni marked this pull request as ready for review February 8, 2022 00:40
@6543 6543 added the build CI pipeline related label Feb 8, 2022
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@anbraten
Copy link
Member

anbraten commented Feb 8, 2022

Isn't this somehow redundant to the work done in #635? We at least use a similar approach for building the cli and agent already.

@6543
Copy link
Member

6543 commented Feb 8, 2022

No its a different one ... beside that xgo use docker but thats a tooling specific to croscimpile cgo

Makefile Outdated Show resolved Hide resolved
@6543 6543 added this to the 0.15.0 milestone Feb 8, 2022
@6543
Copy link
Member

6543 commented Feb 8, 2022

also is it possible to preserver the permissions from user exec that command. at the moment build artefacts are owned by root if run within docker :/

@6543

This comment was marked as off-topic.

@6543
Copy link
Member

6543 commented Feb 10, 2022

make version
> next-22ae7fb8
VERSION=1.0 make version
> 1.0
make in_docker version # expect same as before get ""
>

Makefile Outdated Show resolved Hide resolved
@6543 6543 enabled auto-merge (squash) February 10, 2022 14:08
@6543 6543 merged commit 51904c9 into woodpecker-ci:master Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build CI pipeline related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants