Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect cli argument when checking docker backend availability #3770

Merged
merged 3 commits into from
Jun 10, 2024
Merged

Respect cli argument when checking docker backend availability #3770

merged 3 commits into from
Jun 10, 2024

Conversation

qwerty287
Copy link
Contributor

possibly related to #3195

@qwerty287 qwerty287 added bug Something isn't working backend/docker build_pr_images If set, the CI will build images for this PR and push to Dockerhub labels Jun 6, 2024
@qwerty287 qwerty287 added this to the 2.6.0 milestone Jun 6, 2024
@qwerty287 qwerty287 mentioned this pull request Jun 6, 2024
Closed
5 tasks
@codecov Codecov
Copy link

codecov bot commented Jun 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 25.81%. Comparing base (c724684) to head (256972a).
Report is 6 commits behind head on main.

❗ Current head 256972a differs from pull request most recent head db6e54a

Please upload reports for the commit db6e54a to get more accurate results.

Files Patch % Lines
pipeline/backend/docker/docker.go 0.00% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3770      +/-   ##
==========================================
+ Coverage   25.79%   25.81%   +0.01%     
==========================================
  Files         362      362              
  Lines       26725    26726       +1     
==========================================
+ Hits         6894     6899       +5     
+ Misses      19298    19294       -4     
  Partials      533      533

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anbraten anbraten changed the title Respect cli argument Respect cli argument when checking docker backend availability Jun 10, 2024
@anbraten anbraten enabled auto-merge (squash) June 10, 2024 10:39
@anbraten anbraten merged commit 044c3a6 into woodpecker-ci:main Jun 10, 2024
7 checks passed
@woodpecker-bot
Copy link
Collaborator

Tearing down https://woodpecker-ci-woodpecker-pr-3770.surge.sh

@woodpecker-bot woodpecker-bot mentioned this pull request Jun 10, 2024
Merged
1 task
@qwerty287 qwerty287 deleted the docker-cli branch June 10, 2024 15:25
@BrewTestBot BrewTestBot mentioned this pull request Jun 13, 2024
Merged
6543 pushed a commit to 6543-forks/woodpecker that referenced this pull request Sep 5, 2024
@qwerty287 @anbraten @6543
Respect cli argument when checking docker backend availability (woodp…
fdbdae2 
…ecker-ci#3770)

Co-authored-by: Anbraten <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anbraten anbraten anbraten approved these changes

Assignees
No one assigned
Labels
backend/docker bug Something isn't working build_pr_images If set, the CI will build images for this PR and push to Dockerhub
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@qwerty287 @woodpecker-bot @anbraten