Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spellcheck "server/*" #3753

Merged
merged 12 commits into from
Jun 4, 2024
Merged

Spellcheck "server/*" #3753

merged 12 commits into from
Jun 4, 2024

Conversation

6543
Copy link
Member

@6543 6543 commented Jun 3, 2024

No description provided.

@6543 6543 added the refactor delete or replace old code label Jun 3, 2024
@6543 6543 added this to the 2.6.0 milestone Jun 3, 2024
@woodpecker-bot
Copy link
Collaborator

woodpecker-bot commented Jun 3, 2024 •
edited
Loading

Deployment of preview was torn down

@6543 6543 requested a review from anbraten June 3, 2024 18:40
anbraten
anbraten reviewed Jun 3, 2024
View reviewed changes
cmd/server/flags.go Outdated Show resolved Hide resolved
cmd/server/flags.go Outdated Show resolved Hide resolved
@6543 6543 requested a review from anbraten June 3, 2024 19:32
@anbraten anbraten changed the title lint "server/*" with cspell too Spellcheck "server/*" Jun 3, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 72 lines in your changes missing coverage. Please review.

Project coverage is 25.88%. Comparing base (f47f482) to head (89ed290).
Report is 11 commits behind head on main.

Files Patch % Lines
server/api/login.go 0.00% 20 Missing ⚠️
server/api/stream.go 0.00% 8 Missing ⚠️
cmd/server/setup.go 0.00% 7 Missing ⚠️
server/forge/github/github.go 0.00% 6 Missing ⚠️
...r/forge/bitbucketdatacenter/bitbucketdatacenter.go 0.00% 5 Missing ⚠️
server/services/registry/filesystem.go 0.00% 4 Missing ⚠️
cmd/server/server.go 0.00% 3 Missing ⚠️
server/pipeline/items.go 0.00% 3 Missing ⚠️
server/pipeline/restart.go 0.00% 3 Missing ⚠️
server/api/pipeline.go 0.00% 2 Missing ⚠️
... and 7 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3753      +/-   ##
==========================================
+ Coverage   24.99%   25.88%   +0.88%     
==========================================
  Files         357      361       +4     
  Lines       25767    26648     +881     
==========================================
+ Hits         6441     6898     +457     
- Misses      18833    19220     +387     
- Partials      493      530      +37

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anbraten anbraten merged commit 4ec046e into woodpecker-ci:main Jun 4, 2024
9 checks passed
@woodpecker-bot woodpecker-bot mentioned this pull request Jun 4, 2024
Merged
1 task
@6543 6543 deleted the more-cspell branch June 6, 2024 14:15
@BrewTestBot BrewTestBot mentioned this pull request Jun 13, 2024
Merged
6543 added a commit to 6543-forks/woodpecker that referenced this pull request Sep 5, 2024
@6543 @anbraten @qwerty287
Spellcheck "server/*" (woodpecker-ci#3753)
33b0542 
Co-authored-by: Anbraten <[email protected]>
Co-authored-by: qwerty287 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anbraten anbraten anbraten approved these changes

Assignees
No one assigned
Labels
refactor delete or replace old code
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@6543 @woodpecker-bot @anbraten @qwerty287