Skip golangci in pre-commit.ci #3692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This must be some pre-commit cloud foo... Executing pre-commit locally with this version works as expected. I still think we should just use Woodpecker instead of pre-commit cloud. |
xoxys
approved these changes
May 12, 2024
|
Locally, you usually have the go dependencies installed. I don't think this looks like a pre-commit cloud issue per se, but you would have to download the deps and I have no idea how to do that and don't really know whether that's possible because I assume pre-commit runs all steps in parallel. |
6543
pushed a commit
to 6543-forks/woodpecker
that referenced
this pull request
Sep 5, 2024
Co-authored-by: Robert Kaussow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like something has changed for golangci-lint and it breaks our current workflows. See for example https://results.pre-commit.ci/run/github/410589193/1714881301.sLyiCpR2QZODkjw5ZZUs7w. Probably, you have to download go modules but I don't really know whether that's possible.